Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OpenSSL: fix yet another mistake while encapsulating SSL backend data
Another mistake in my manual fixups of the largely mechanical search-and-replace ("connssl->" -> "BACKEND->"), just like the previous commit concerning HTTPS proxies (and hence not caught during my earlier testing). Fixes #1855 Closes #1871 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
- Loading branch information
f4a6238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should check the proxy SSL handle separate, isn't it possible we're going to run into situations where the proxy ssl handle exists but the destination server ssl handle does not?
if(BACKEND->handle && SSL_pending(BACKEND->handle))
return TRUE;
if(proxyssl->backend->handle && SSL_pending(proxyssl->backend->handle))
return TRUE;
return FALSE;
gtls does it this way. for comparison:
curl/lib/vtls/gtls.c
Lines 1527 to 1542 in c73ebb8