Skip to content

Commit

Permalink
Curl_chunker: shrink the struct
Browse files Browse the repository at this point in the history
... by removing a field, converting the hex index into a byte and
rearranging the order. Cuts it down from 48 bytes to 32 on x86_64.
  • Loading branch information
bagder committed Jan 26, 2021
1 parent 234638e commit ffba7a3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 15 deletions.
3 changes: 1 addition & 2 deletions lib/http_chunks.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ void Curl_httpchunk_init(struct Curl_easy *data)
struct connectdata *conn = data->conn;
struct Curl_chunker *chunk = &conn->chunk;
chunk->hexindex = 0; /* start at 0 */
chunk->dataleft = 0; /* no data left yet! */
chunk->state = CHUNK_HEX; /* we get hex first! */
Curl_dyn_init(&conn->trailer, DYN_H1_TRAILER);
}
Expand Down Expand Up @@ -309,7 +308,7 @@ CHUNKcode Curl_httpchunk_read(struct Curl_easy *data,

/* Record the length of any data left in the end of the buffer
even if there's no more chunks to read */
ch->dataleft = curlx_sotouz(length);
ch->datasize = curlx_sotouz(length);

return CHUNKE_STOP; /* return stop */
}
Expand Down
9 changes: 4 additions & 5 deletions lib/http_chunks.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ typedef enum {
big deal. */
CHUNK_POSTLF,

/* Used to mark that we're out of the game. NOTE: that there's a 'dataleft'
/* Used to mark that we're out of the game. NOTE: that there's a 'datasize'
field in the struct that will tell how many bytes that were not passed to
the client in the end of the last buffer! */
CHUNK_STOP,
Expand Down Expand Up @@ -83,11 +83,10 @@ typedef enum {
const char *Curl_chunked_strerror(CHUNKcode code);

struct Curl_chunker {
char hexbuffer[ CHUNK_MAXNUM_LEN + 1]; /* +1 for null-terminator */
int hexindex;
ChunkyState state;
curl_off_t datasize;
size_t dataleft; /* untouched data amount at the end of the last buffer */
ChunkyState state;
unsigned char hexindex;
char hexbuffer[ CHUNK_MAXNUM_LEN + 1]; /* +1 for null-terminator */
};

/* The following functions are defined in http_chunks.c */
Expand Down
14 changes: 6 additions & 8 deletions lib/transfer.c
Original file line number Diff line number Diff line change
Expand Up @@ -752,17 +752,15 @@ static CURLcode readwrite_data(struct Curl_easy *data,
return CURLE_RECV_ERROR;
}
if(CHUNKE_STOP == res) {
size_t dataleft;
/* we're done reading chunks! */
k->keepon &= ~KEEP_RECV; /* read no more */

/* There are now possibly N number of bytes at the end of the
str buffer that weren't written to the client.
Push it back to be read on the next pass. */

dataleft = conn->chunk.dataleft;
if(dataleft != 0) {
infof(data, "Leftovers after chunking: %zu bytes\n", dataleft);
/* N number of bytes at the end of the str buffer that weren't
written to the client. */
if(conn->chunk.datasize) {
infof(data, "Leftovers after chunking: % "
CURL_FORMAT_CURL_OFF_T "u bytes\n",
conn->chunk.datasize);
}
}
/* If it returned OK, we just keep going */
Expand Down

0 comments on commit ffba7a3

Please sign in to comment.