Skip to content

keywords.pl broken by conditional & alternation lines in tests #10895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dfandrich opened this issue Apr 5, 2023 · 1 comment
Closed

keywords.pl broken by conditional & alternation lines in tests #10895

dfandrich opened this issue Apr 5, 2023 · 1 comment
Labels
script tests

Comments

@dfandrich
Copy link
Contributor

Several tests use %if clauses in the <errorcode> section of tests (e.g. 178) and others use a list of <errorcode> values (e.g. 405). These are not handled properly and result in (presumably) incorrect statistical output, at least. These warnings are shown when perl warnings are enabled:

Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "35,28\n" isn't numeric in addition (+) at keywords.pl line 75.
Argument "%if hyper\n" isn't numeric in addition (+) at keywords.pl line 75.
Invalid conversion in printf: "%he" at keywords.pl line 138.
Invalid conversion in printf: "%{" at keywords.pl line 138.
Invalid conversion in printf: "%T" at keywords.pl line 138.
@bagder
Copy link
Member

bagder commented Apr 6, 2023

Oh right. Yeah, anything that parses the test files really need to parse the preprocessed output version rather than the source version if they cannot handle the preprocess instructions.

To make keywords.pl work again, I suppose we need to enhance runtests.pl in a way so that we can invoke it to only generate the log/testNUM file (possibly on stdout) and then have keywords.pl use that...

bagder added a commit to curl/curl-www that referenced this issue Apr 14, 2023
@bagder
dev/update.pl: remove the keywords invoke
f445050 
The script does not work anymore. See
curl/curl#10895
bagder added a commit that referenced this issue Apr 17, 2023
@bagder
tests/keywords.pl: remove
6203166 
This script does not work since the introduction of the test
processing. If we need this functionality, it probably needs to be moved
into the runtests tool or similar.

Reported-by: Dan Fandrich
Fixes #10895
@bagder bagder mentioned this issue Apr 17, 2023
Closed
@bagder bagder closed this as completed in 1c5ed24 Apr 17, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
tests/keywords.pl: remove
90af01f 
This script does not work since the introduction of the test
preprocessing. If we need this functionality, it probably needs to be
moved into the runtests tool or similar.

Reported-by: Dan Fandrich
Fixes curl#10895
Closes curl#10987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
script tests
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/keywords.pl: remove curl/curl
2 participants
@bagder @dfandrich