Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl 8.1.1 configure hangs for multilib build #11179

Closed
eworm-de opened this issue May 23, 2023 · 5 comments
Closed

curl 8.1.1 configure hangs for multilib build #11179

eworm-de opened this issue May 23, 2023 · 5 comments
Assignees
@bagder
Labels
build

Comments

@eworm-de
Copy link
Contributor

I did this

I was packaging curl 8.1.1 for Arch Linux. Building the regular curl package ( x86-64) succeeds, building lib32-curl package (multilib) fails, it hangs in configure:

[...]
checking if compiler is clang... no
checking if compiler is GNU C... yes
checking if compiler is LCC... no
checking if compiler is SGI MIPSpro C... no
checking if compiler is SGI MIPS C... no
checking if compiler is SunPro C... no
checking if compiler is Tiny C... no
checking if compiler accepts some basic options... ^C

The command that is running:

sh ./run-compiler -o conftest -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -g -ffile-prefix-map=/build/lib32-curl/src=/usr/src/debug/lib32-curl -flto=auto -Werror-implicit-function-declaration -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto conftest.c

Looks like the offending commit is b78ca50... Reverting that makes the build succeed.

I expected the following

The package should succeed to build.

curl/libcurl version

Fails to build... So no output. 😝

operating system

Linux leda.eworm.net 6.3.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Sun, 21 May 2023 16:15:22 +0000 x86_64 GNU/Linux
@bagder bagder added the build label May 23, 2023
@bagder
Copy link
Member

bagder commented May 23, 2023

Can you figure out why it hangs? The script it runs is very simple...

@bagder bagder self-assigned this May 23, 2023
@eworm-de
Copy link
Contributor Author

eworm-de commented May 23, 2023 •
edited
Loading

The script run-compiler contains:

CC=gcc -m32
LD_LIBRARY_PATH=
exec $CC $@

@eworm-de
Copy link
Contributor Author

Is it missing a quote? Let me test...

@bagder
Copy link
Member

bagder commented May 23, 2023

This patch would add quotes:

diff --git a/configure.ac b/configure.ac
index 75a882b12..1f822d16f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -191,11 +191,11 @@ dnl Generates a shell script to run the compiler with LD_LIBRARY_PATH set to
 dnl the value used right now. This lets CURL_RUN_IFELSE set LD_LIBRARY_PATH to
 dnl something different but only have that affect the execution of the results
 dnl of the compile, not change the libraries for the compiler itself.
 dnl
 compilersh="run-compiler"
-echo "CC=$CC" > $compilersh
+echo "CC=\"$CC\"" > $compilersh
 echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH" >> $compilersh
 echo 'exec $CC $@' >> $compilersh
 
 dnl **********************************************************************
 dnl See which TLS backend(s) that are requested. Just do all the

eworm-de added a commit to eworm-de/curl that referenced this issue May 23, 2023
@eworm-de
configure: quote the compiler command
21604a3 
Building for multilib failed, as the compiler command contains an
extra argument. That needs quoting.

Fixes curl#11179
Fixes b78ca50
@eworm-de eworm-de mentioned this issue May 23, 2023
Closed
@eworm-de
Copy link
Contributor Author

Yes, my patch looks the same. 😉

@bagder bagder changed the title configure hangs for multilib build curl 8.1.1 configure hangs for multilib build May 23, 2023
@bagder bagder pinned this issue May 23, 2023
@bagder bagder closed this as completed in 471dab2 May 23, 2023
@bagder bagder mentioned this issue May 23, 2023
Closed
@tawmoto tawmoto mentioned this issue May 23, 2023
Closed
@gvanem gvanem unpinned this issue May 25, 2023
@bagder bagder mentioned this issue May 26, 2023
Closed
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@eworm-de @bch
configure: quote the assignments for run-compiler
25a6363 
Building for multilib failed, as the compiler command contains an
extra argument. That needs quoting.

Regression from b78ca50

Fixes curl#11179
Closes curl#11180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: quote the compiler command eworm-de/curl
2 participants
@bagder @eworm-de