Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #148

Closed
elfring opened this issue Mar 6, 2015 · 2 comments
Closed

reserved identifier violation #148

elfring opened this issue Mar 6, 2015 · 2 comments
Assignees
@bagder

Comments

@elfring
Copy link
Contributor

elfring commented Mar 6, 2015

I would like to point out that identifiers like "__CURL_CURLVER_H" and "__CURL_MULTI_H" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@bagder
Copy link
Member

bagder commented Mar 6, 2015

This is not a problem in the real world though. libcurl is more portable than most projects and we've had such identifiers for at least 15 years. If someone brings a patch for it then I'll merge but I don't think it is worth wasting many cycles on.

@bagder bagder self-assigned this Mar 6, 2015
@bagder bagder closed this as completed Mar 7, 2015
elfring added a commit to elfring/curl that referenced this issue Mar 7, 2015
@elfring
Bug curl#148: Fix include guards.
5629943 
Some include guards did not fit to the expected naming convention of
the C language standard.
http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier

This implementation detail could be fixed by deletion of a few underscores.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
@elfring
Copy link
Contributor Author

elfring commented Mar 29, 2015

Would you like to achieve that your C/C++ source files will become standard-compliant?

@lock Lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @elfring