[regression] rtorrent breaks by commit "extract_if_dead: follow-up to 54b201b48c90a" #3542

Activity

1. bagder commented on Feb 8, 2019

   

   bagder

   on Feb 8, 2019

   Member

   More actions

   I would urge you to try to come up with an example source code that only uses libcurl to allow us to reproduce the problem and help out the debugging. I will not be productive to have us build and try to untangle a full rtorrent build for this purpose.
2. tholin commented on Feb 9, 2019

   

   tholin

   on Feb 9, 2019

   Author

   More actions

   I don't know anything about the libcurl api, how it's supposed to be used or how rtorrent use it. Investigating would take a lot of time and since I already have a workaround it would not be productive for me.

   I wanted to at least let you know that commit broke a downstream project. I'll file a bug report to my distribution. Perhaps the maintainer there wants to investigate it.
3. jay commented on Feb 10, 2019

   

   jay

   on Feb 10, 2019

   Member

   More actions

   @tholin can you try the patch at #3541 (comment)
4. tholin commented on Feb 11, 2019

   

   tholin

   on Feb 11, 2019

   Author

   More actions

   @tholin can you try the patch at #3541 (comment)

   I applied the patch to curl-7.64.0 but it had no effect. Rtorrent still started epolling like before.
5. jay commented on Feb 11, 2019

   

   jay

   on Feb 11, 2019

   Member

   More actions

   Ok. Patch worked for the other reporter and is in master now. I don't know what could be causing it. Are you using proxies by any chance? Can you try master and this:

   diff --git a/lib/url.c b/lib/url.c
   index bc47685..f24a650 100644
   --- a/lib/url.c
   +++ b/lib/url.c
   @@ -964,8 +964,10 @@ static bool extract_if_dead(struct connectdata *conn,
          /* The protocol has a special method for checking the state of the
             connection. Use it to check if the connection is dead. */
          unsigned int state;
   +      struct Curl_easy *olddata = conn->data;
          conn->data = data; /* use this transfer for now */
          state = conn->handler->connection_check(conn, CONNCHECK_ISDEAD);
   +      conn->data = olddata;
          dead = (state & CONNRESULT_DEAD);
        }
        else {
6. tholin commented on Feb 11, 2019

   

   tholin

   on Feb 11, 2019

   Author

   More actions

   I first confirmed that the problem still exists in master (cac0e4a) and then I applied the patch but it had no effect.

   I'm not using any proxy. Here is my rtorrent.rc config if it helps:

   bind=0.0.0.0
   throttle.min_peers.normal.set = 60
   throttle.max_peers.normal.set = 150
   network.port_range.set = 8000-8000
   protocol.pex.set = yes
   directory.default.set = /mnt/virtual/torrent
   dht.mode.set = on
   dht.port.set = 6881
   schedule = watch_directory,10,10,load.start=/mnt/virtual/torrent/*.torrent
   group.seeding.ratio.enable=
   ratio.min.set=110
   session.path.set = /home/tholin/.rtorrent
   ipv4_filter.load = ~/.rtorrent_blocklist,unwanted
   file.prioritize_toc.set=1
   encoding.add = UTF-8
   
7. jay commented on Feb 11, 2019

   

   jay

   on Feb 11, 2019

   Member

   More actions

   Ok. How about this:

   diff --git a/lib/url.c b/lib/url.c
   index bc47685..46c8fb5 100644
   --- a/lib/url.c
   +++ b/lib/url.c
   @@ -964,8 +964,10 @@ static bool extract_if_dead(struct connectdata *conn,
          /* The protocol has a special method for checking the state of the
             connection. Use it to check if the connection is dead. */
          unsigned int state;
   +      struct Curl_easy *olddata = conn->data;
          conn->data = data; /* use this transfer for now */
          state = conn->handler->connection_check(conn, CONNCHECK_ISDEAD);
   +      conn->data = olddata;
          dead = (state & CONNRESULT_DEAD);
        }
        else {
   @@ -994,7 +996,6 @@ struct prunedead {
    static int call_extract_if_dead(struct connectdata *conn, void *param)
    {
      struct prunedead *p = (struct prunedead *)param;
   -  conn->data = p->data; /* transfer to use for this check */
      if(extract_if_dead(conn, p->data)) {
        /* stop the iteration here, pass back the connection that was extracted */
        p->extracted = conn;
8. tholin commented on Feb 11, 2019

   

   tholin

   on Feb 11, 2019

   Author

   More actions

   This latest patch on master works fine. I ran it for 45 min to make sure and there is no excessive epolling with it.
9. jay commented on Feb 12, 2019

   

   jay

   on Feb 12, 2019

   Member

   More actions

   Thanks for testing, I turned the patch into #3559 for review.
10. bagder

    closed this as completedin 4015faeon Feb 14, 2019
11. lock

    locked as resolved and limited conversation to collaborators on May 15, 2019