Running curl with --doh-url seems to turn on verbose output #3660

Activity

1. jay commented on Mar 9, 2019

   

   jay

   on Mar 9, 2019

   Member

   More actions

   Confirmed.

   diff --git a/lib/doh.c b/lib/doh.c
   index f06ed33..746b8ca 100644
   --- a/lib/doh.c
   +++ b/lib/doh.c
   @@ -242,7 +242,6 @@ static CURLcode dohprobe(struct Curl_easy *data,
        ERROR_CHECK_SETOPT(CURLOPT_PROTOCOLS, CURLPROTO_HTTPS);
    #endif
        ERROR_CHECK_SETOPT(CURLOPT_TIMEOUT_MS, (long)timeout_ms);
   -    ERROR_CHECK_SETOPT(CURLOPT_VERBOSE, 1L);
        doh->set.fmultidone = Curl_doh_done;
        doh->set.dohfor = data; /* identify for which transfer this is done */
        p->easy = doh;

   @bagder left in by accident?
2. jay commented on Mar 9, 2019

   

   jay

   on Mar 9, 2019

   Last edited by jay

   Member

   More actions

   on second thought it should inherit from the easy handle

   diff --git a/lib/doh.c b/lib/doh.c
   index f06ed33..5040248 100644
   --- a/lib/doh.c
   +++ b/lib/doh.c
   @@ -242,7 +242,8 @@ static CURLcode dohprobe(struct Curl_easy *data,
        ERROR_CHECK_SETOPT(CURLOPT_PROTOCOLS, CURLPROTO_HTTPS);
    #endif
        ERROR_CHECK_SETOPT(CURLOPT_TIMEOUT_MS, (long)timeout_ms);
   -    ERROR_CHECK_SETOPT(CURLOPT_VERBOSE, 1L);
   +    if(data->set.verbose)
   +      ERROR_CHECK_SETOPT(CURLOPT_VERBOSE, 1L);
        doh->set.fmultidone = Curl_doh_done;
        doh->set.dohfor = data; /* identify for which transfer this is done */
        p->easy = doh;

   also what's a good test site for doh, I tried cloudflare but it's not working

   curld -v --doh-url https://cloudflare-dns.com/dns-query http://www.test.com
   ...
   * DOH: Too small type A for www.test.com
   * DOH: Too small type AAAA for www.test.com
   

   It's a bug because CAINFO is not inherited and I need that in Windows. PR in #3661 to fix that and the OP's issue. And test sites are here.
3. jay

   added a commit that references this issue on Mar 9, 2019

   doh: inherit more SSL options from easy handle

   ...

   68c7276
4. bagder commented on Mar 9, 2019

   

   bagder

   on Mar 9, 2019

   Member

   More actions

   left in by accident?

   Oops...
5. bagder

   added

   name lookupDNS and related techDNS and related tech

   on Mar 10, 2019
6. jay

   added a commit that references this issue on Mar 11, 2019

   doh: inherit some SSL options from user's easy handle

   ...

   9e6af11
7. jay

   closed this as completedin 9e6af11on Mar 11, 2019
8. jay commented on Mar 11, 2019

   

   jay

   on Mar 11, 2019

   Member

   More actions

   Thanks
9. lock

   locked as resolved and limited conversation to collaborators on Jun 9, 2019