cppcheck complains about lib/asyn-ares.c:459

[rl1987]

Ran cppcheck on curl master (2d137de) and got the following warning:

lib/asyn-thread.c:596:4: error: Null pointer dereference: entry [ctunullpointer]
  *entry = NULL;
   ^
lib/asyn-ares.c:459:39: note: Calling function Curl_resolver_is_resolved, 2nd argument is null
    result = Curl_resolver_is_resolved(conn, entry?&temp_entry:NULL);
                                      ^
lib/asyn-thread.c:596:4: note: Dereferencing argument entry that is null
  *entry = NULL;
   ^

As far as I can tell NULL pointer dereference cannot really happen, but this probably should be fixed anyway.

[jay]

Yes it cannot happen because those two are mutually exclusive, either the threaded or ares resolver is used and we have an internal resolver interface, so there is a Curl_resolver_is_resolved in both asyn-ares and asyn-thread. I fixed it anyway to silence cppcheck and make the interface consistent. Thanks.