Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyn-: remove support for never-used NULL entry pointers #5324

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

bagder commented May 2, 2020

... and instead convert those to asserts to make sure they are truly
never NULL.

@jay
Copy link
Member

jay commented May 2, 2020

It looks like this was meant to address #5326? I didn't realize that when I put in 153d581.

@bagder
Copy link
Member Author

bagder commented May 2, 2020

If you look again you'll see that I posted this PR before #5326 was created, so yes I fixed that issue here before it was filed...

... and instead convert those to asserts to make sure they are truly
never NULL.
@bagder bagder force-pushed the bagder/async-ares-null-entry branch from a69b768 to 39b6ae6 May 2, 2020
@jay
Copy link
Member

jay commented May 2, 2020

If you look again you'll see that I posted this PR before #5326 was created, so yes I fixed that issue here before it was filed...

Ah. I concur. I've walked back all the calls and I couldn't find a single place where the entry pointer passed would end up being NULL.

@bagder bagder closed this in 59e351a May 3, 2020
@bagder bagder deleted the bagder/async-ares-null-entry branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.