asyn-: remove support for never-used NULL entry pointers - #5324
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Member
Member
Author
|
If you look again you'll see that I posted this PR before #5326 was created, so yes I fixed that issue here before it was filed... |
... and instead convert those to asserts to make sure they are truly never NULL.
bagder
force-pushed
the
bagder/async-ares-null-entry
branch
from
May 2, 2020 20:46
a69b768 to
39b6ae6
Compare
Member
Ah. I concur. I've walked back all the calls and I couldn't find a single place where the entry pointer passed would end up being NULL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and instead convert those to asserts to make sure they are truly
never NULL.