Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appveyor autotools builds run no tests? #6120

Closed
bagder opened this issue Oct 22, 2020 · 5 comments
Closed

Appveyor autotools builds run no tests? #6120

bagder opened this issue Oct 22, 2020 · 5 comments
Labels
CI Continuous Integration Windows Windows-specific

Comments

@bagder
Copy link
Member

bagder commented Oct 22, 2020 •
edited
Loading

I did this

I checked the appveyor builds for #6117 and noticed that the three autotools builds now fail because no test runs!

example build

I expected the following

It should run plenty tests

curl/libcurl version

current git master

operating system

windows

/cc @mback2k ideas?
@bagder bagder added Windows Windows-specific CI Continuous Integration labels Oct 22, 2020
@mback2k
Copy link
Member

mback2k commented Oct 22, 2020

This line looks interesting, especially since the tests were running on AppVeyor in the past:
TESTINFO: "disabled by missing keyword" 1019 times (1, 2, 3, 4, 6, 7, 8, 9, 10 and 1010 more)
https://ci.appveyor.com/project/curlorg/curl/builds/35899795/job/g8xptp4vw5ihkn9u#L2450

Did you try to find the last commit that ran the tests?

@mback2k
Copy link
Member

mback2k commented Oct 22, 2020 •
edited
Loading

I will try to find the commit that broke it since the latest release at which time the tests still ran:
TESTDONE: 1086 tests out of 1088 reported OK: 99%
https://ci.appveyor.com/project/curlorg/curl/builds/35740880/job/5tt0b6ac2x5kpwad#L7430

@mback2k
Copy link
Member

mback2k commented Oct 22, 2020

This is the first commit not running tests in the autotools build on AppVeyor: 15997f6

Seems like the removal of these tests caused a change in the keyword handling maybe?

@bagder
Copy link
Member Author

bagder commented Oct 22, 2020

Very puzzling! If that commit broke something, how come it only broke it for autotools builds on appveyor?

@jay jay mentioned this issue Oct 25, 2020
Closed
jay referenced this issue Oct 26, 2020
@bagder
CI/appveyor: remove (unused) runtests.pl -b option
e2bcdf5
@jay
Copy link
Member

jay commented Oct 26, 2020

Fixed by e2bcdf5.

@jay jay closed this as completed Oct 26, 2020
@bagder bagder mentioned this issue Oct 26, 2020
Closed
bagder added a commit that referenced this issue Oct 26, 2020
@bagder
runtests: show keywords when no tests ran
61630a1 
To help out future debugging, runtests now outputs the list of keywords
when it fails because no tests ran.

Ref: #6120
Closes #6126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Windows Windows-specific
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bagder @mback2k @jay