HTTP/2 connection reuse is broken in 7.49.1

[gevaerts]

curl --http1.1 -v https://http2bin.org/get https://http2bin.org/get
curl --http2 -v https://http2bin.org/get https://http2bin.org/get

The problem is that the version detection in lib/http.c around line 3310 assumes HTTP/major.minor, and 8243a95 changes that, so HTTP/2 gets detected as 10, which then makes a lot of code fall back to HTTP/1.0 behaviour such as connection closing.

Note that 8243a95 was committed between 7.49 and 7.49.1, so the current released version (7.49.1) is affected.

[bagder]

Ouch. And no test caught it... =( I guess it also tells us we should add a test for this together with the fix.

[gevaerts]

(found by adu on irc, by the way, not by me)

[andydude]

I (I'm adu on irc) have a fix for this, but I'm still running the tests to see if there are any regressions.

[jay]

We fixed this in 1aa899f, thanks.

[Jesin]

This also caused the -L/--location flag to be ignored when curl 7.49.1 uses HTTP/2. This has broken a few scripts. The flag seems to work again as of f9eed59. Would this be worth making another bugfix release, or is 7.50 close to finished?

[bagder]

I don't see how this should cause the --location to get ignored, that sounds like a separate issue!

7.50.0 is due to be released on July 21 so there will be no 7.49.X patch release before that.

[jay]

@bagder It looks as though that was a symptom of the parsing bug. When http2 status parsing failed the code defaulted to 200 (ouch indeed).