Remove deprecated symbols checks as it is past November 25, 2022. #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignore commit 40ae104, updated wrong branch, sorry. |
jzakrzewski
reviewed
Jan 18, 2023
CMakeLists.txt
Outdated
| @@ -98,7 +98,7 @@ include_directories(${CURL_SOURCE_DIR}/include) | |||
|
|
|||
| option(CURL_WERROR "Turn compiler warnings into errors" OFF) | |||
| option(PICKY_COMPILER "Enable picky compiler options" ON) | |||
| option(BUILD_CURL_EXE "Set to ON to build curl executable." ON) | |||
| option(BUILD_CURL_EXE "Set to ON to build curl executable." OFF) | |||
There was a problem hiding this comment.
Modified wrong fork. See above comment, sorry
|
Did you close this by accident? Do you want us to remove the deprecated symbols? @jzakrzewski what do you think |
|
I think this removal is perfectly in order. Those options were only supported to give people some time to update their scripts. |
This reverts commit 40ae104.
I just updated my fork to remove the accidental change and now reflects the initial PR. Should be good for merge if you guys think so, thanks. |
|
Thanks |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
curl stopped use of CMAKE_USE_ as a prefix for its own build symbols in 2021 and added a check, meant to last 1 year, to fatally error on those symbols. This commit removes that check. Closes curl#10314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the CMakeLists.txt, the deprecated symbols checks in CMakeLists.txt should be removed after November 25th 2022.