Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated symbols checks as it is past November 25, 2022. #10314

Closed
wants to merge 3 commits into from

Conversation

xgladius
Copy link

As stated in the CMakeLists.txt, the deprecated symbols checks in CMakeLists.txt should be removed after November 25th 2022.

Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit but I'll leave final call on this to @jay who committed this in 0969805.

@xgladius xgladius closed this Jan 18, 2023
@xgladius
Copy link
Author

ignore commit 40ae104, updated wrong branch, sorry.

CMakeLists.txt Outdated
@@ -98,7 +98,7 @@ include_directories(${CURL_SOURCE_DIR}/include)

option(CURL_WERROR "Turn compiler warnings into errors" OFF)
option(PICKY_COMPILER "Enable picky compiler options" ON)
option(BUILD_CURL_EXE "Set to ON to build curl executable." ON)
option(BUILD_CURL_EXE "Set to ON to build curl executable." OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified wrong fork. See above comment, sorry

@jay
Copy link
Member

jay commented Jan 20, 2023

Did you close this by accident? Do you want us to remove the deprecated symbols? @jzakrzewski what do you think

@jay jay added the cmake label Jan 20, 2023
@jzakrzewski
Copy link
Contributor

I think this removal is perfectly in order. Those options were only supported to give people some time to update their scripts.
Sure, if someone does a big leap, they'll be surprised, but then that's what you for not updating regularly.

@jay jay reopened this Jan 20, 2023
@xgladius
Copy link
Author

Did you close this by accident? Do you want us to remove the deprecated symbols? @jzakrzewski what do you think

I just updated my fork to remove the accidental change and now reflects the initial PR. Should be good for merge if you guys think so, thanks.

@jay jay closed this in ac6e7f5 Jan 20, 2023
@jay
Copy link
Member

jay commented Jan 20, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants