dict: URL decode the entire path always #10354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I thought the labeler bot was configured to leave existing labels alone. I suspect if it were quicker and labeled this PR before you, all would have been fine. |
|
When I create PRs I always set the labels at creation time. Then the bot can't do it before me... |
|
Unfortunately our DICT test server is too basic to allow us to verify this with a test case. Some of the CI errors is due to this => #10356 |
bagder
force-pushed
the
bagder/dict-url-decode
branch
from
9896c80
to
c487e61
Compare
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Reported-by: dekerser on github Fixes curl#10298 Closes curl#10354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: dekerser on github
Fixes #10298