tool: improve --stderr handling #10673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| else | ||
| global->errors = stdout; | ||
| tool_set_stderr_file(nextarg); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
|
||
| /* precheck that filename is accessible to lessen the chance that the | ||
| subsequent freopen will fail. */ | ||
| fp = fopen(filename, FOPEN_WRITETEXT); |
Check failure
Code scanning / CodeQL
File created without restricting permissions
jay
force-pushed
the
improve_stderr
branch
2 times, most recently
from
675799e
to
af1df98
Compare
|
I'm not sure I see how this simplifies or improves the current situation, but if you think so then I am fine with it. |
|
It's an improvement to fprintf(stderr... rather than a separate error stream, when all stderr output is supposed to be redirected, since in the latter case we forgot at least once which led to a bug. It's failing some CI so I'm still working on it. |
- freopen stderr with the user-specified file (--stderr file) instead of using a separate 'errors' stream. - Override stderr macro in tool_setup as global variable tool_stderr. Both freopen and overriding the stderr macro are necessary because if the user-specified filename is "-" then stdout is assigned to tool_stderr and no freopen takes place. See the PR for more information. Ref: curl#10491 Closes #xxxx
GerHobbelt
added a commit
to GerHobbelt/thirdparty-curl
that referenced
this pull request
Mar 15, 2023
* tool: improve --stderr handling - freopen stderr with the user-specified file (--stderr file) instead of using a separate 'errors' stream. - In tool_setup.h override stdio.h's stderr macro as global variable tool_stderr. Both freopen and overriding the stderr macro are necessary because if the user-specified filename is "-" then stdout is assigned to tool_stderr and no freopen takes place. See the PR for more information. Ref: curl/curl#10491 Closes curl/curl#10673
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- freopen stderr with the user-specified file (--stderr file) instead of using a separate 'errors' stream. - In tool_setup.h override stdio.h's stderr macro as global variable tool_stderr. Both freopen and overriding the stderr macro are necessary because if the user-specified filename is "-" then stdout is assigned to tool_stderr and no freopen takes place. See the PR for more information. Ref: curl#10491 Closes curl#10673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freopen stderr with the user-specified file (--stderr file) instead of using a separate 'errors' stream.
Override stderr macro in tool_setup as global variable tool_stderr.
Both freopen and overriding the stderr macro are necessary because if the user-specified filename is "-" then stdout is assigned to tool_stderr and no freopen takes place.
Ref: #10491
Closes #xxxx
Note --stderr maps to libcurl's CURLOPT_STDERR but they are documented differently:
--stderr :
"Redirect all writes to stderr"
CURLOPT_STDERR :
"when showing the progress meter and displaying CURLOPT_VERBOSE data"
If the curl tool has freopened stderr as a file (--stderr file) then libcurl stderr output will also go to the file. OTOH if stdout was specified (--stderr -) then libcurl writes to stderr go to actual stderr and just the criteria above is written to stdout. IMO the distinction is moot since in libcurl we only write to stderr for developer debug output.