ftplistparser: hide private data, switch to dynbuf from custom realloc #10844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public 'curl_fileinfo' struct contained three fields that are for internal purposes only. This change makes them unused in the public struct. The new private struct fields are also renamed to make this separation more obvious internally. Closes #10844
bagder
force-pushed
the
bagder/ftplistparser
branch
from
577d869 to
46414ff
Compare
bagder
added a commit
that referenced
this pull request
Mar 28, 2023
bagder
added a commit
that referenced
this pull request
Mar 28, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
The public 'curl_fileinfo' struct contained three fields that are for internal purposes only. This change makes them unused in the public struct. The new private struct fields are also renamed to make this separation more obvious internally. Closes curl#10844
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public struct contains three fields that are actually private, but with this change those fields are no longer used.
Switch from the custom realloc to using dynbuf for managing the FTP response parsing buffer.