Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftplistparser: hide private data, switch to dynbuf from custom realloc #10844

Closed
wants to merge 5 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 27, 2023

The public struct contains three fields that are actually private, but with this change those fields are no longer used.

Switch from the custom realloc to using dynbuf for managing the FTP response parsing buffer.

The public 'curl_fileinfo' struct contained three fields that are for
internal purposes only. This change makes them unused in the public
struct.

The new private struct fields are also renamed to make this separation
more obvious internally.

Closes #10844
@bagder bagder closed this in 01114f6 Mar 28, 2023
bagder added a commit that referenced this pull request Mar 28, 2023
bagder added a commit that referenced this pull request Mar 28, 2023
@bagder bagder deleted the bagder/ftplistparser branch March 28, 2023 08:13
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
The public 'curl_fileinfo' struct contained three fields that are for
internal purposes only. This change makes them unused in the public
struct.

The new private struct fields are also renamed to make this separation
more obvious internally.

Closes curl#10844
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant