vtls and h2 improvements #10891
vtls and h2 improvements #10891
Conversation
- eliminate receive loop in vtls to fill buffer. This may lead to partial reads of data which is counter productive - let http2 instead loop smarter to process pending network data without transfer switches scorecard improvements - do not start caddy when only httpd is requested - allow curl -v to stderr file on --curl-verbose
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -364,7 +365,7 @@ def score_proto(self, proto: str, | |||
| p['version'] = Env.curl_lib_version(p['implementation']) | |||
|
|
|||
| score = { | |||
| 'curl': self.env.curl_version(), | |||
| 'curl': self.env.curl_fullname(), | |||
There was a problem hiding this comment.
reportOptionalMemberAccess: "curl_fullname" is not a known member of "None"
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
tests/http/scorecard.py
Outdated
| url10 = f'https://{self.env.domain1}:{port}/score10.data' | ||
| self._make_docs_file(docs_dir=self.caddy.docs_dir, fname='score100.data', fsize=100 * 1024 * 1024) | ||
| self._make_docs_file(docs_dir=self.caddy.docs_dir, | ||
| fname='score100.data', fsize=100 * 1024 * 1024) |
There was a problem hiding this comment.
E501: line too long (80 > 79 characters)
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -404,12 +428,13 @@ def print_score(self, score): | |||
| print(f' {key:<17} {self.fmt_ms(val["ipv4-connect"]):>12} ' | |||
| f'{self.fmt_ms(val["ipv4-handshake"]):>12} ' | |||
| f'{self.fmt_ms(val["ipv6-connect"]):>12} ' | |||
| f'{self.fmt_ms(val["ipv6-handshake"]):>12} {"/".join(val["ipv4-errors"] + val["ipv6-errors"]):<20}' | |||
| f'{self.fmt_ms(val["ipv6-handshake"]):>12} ' | |||
| f'{"/".join(val["ipv4-errors"] + val["ipv6-errors"]):<20}' | |||
There was a problem hiding this comment.
E501: line too long (80 > 79 characters)
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
tests/http/scorecard.py
Outdated
| @@ -228,11 +238,14 @@ def downloads(self, proto: str, test_httpd: bool = True, | |||
| via = 'httpd' | |||
| descr = f'port {port}' | |||
| self.info(f'{via} downloads\n') | |||
| self._make_docs_file(docs_dir=self.httpd.docs_dir, fname='score1.data', fsize=1024*1024) | |||
| self._make_docs_file(docs_dir=self.httpd.docs_dir, | |||
There was a problem hiding this comment.
reportOptionalMemberAccess: "docs_dir" is not a known member of "None"
❗❗ 3 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| tests/http/scorecard.py | 244 |
| tests/http/scorecard.py | 247 |
| tests/http/scorecard.py | 334 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
Thanks! |
- eliminate receive loop in vtls to fill buffer. This may lead to partial reads of data which is counter productive - let http2 instead loop smarter to process pending network data without transfer switches scorecard improvements - do not start caddy when only httpd is requested - allow curl -v to stderr file on --curl-verbose Closes curl#10891
scorecard improvements