Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: speed up and extend picky clang/gcc options #10973

Closed
wants to merge 4 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 16, 2023

Extend existing picky compiler options with ones missing compared to autotools builds. Also sync options between clang and gcc.

Redesign the way we enable these options to avoid the slow option detection almost completely.

This reduces the number of detections from 35 to zero for clang and 3 for gcc, even after adding a bunch of new options.

clang 3.0 (2011-11-29) and gcc 2.95 (1999-07-31) now required.

Also show enabled picky options.

Ref: libssh2/libssh2#952

Closes #10973

Extend existing picky compiler options with ones missing compared to
autotools builds. Also sync options between clang and gcc.

Redesign the way we enable these options to avoid the slow option
detection almost completely.

This reduces the number of detections from 35 to zero for clang
and 3 for gcc, even after adding a bunch of new options.

clang 3.0 (2011-11-29) and gcc 2.95 (1999-07-31) now required.

Also show enabled picky options.

Ref: libssh2/libssh2#952

Closes #xxxxx
@vszakats vszakats changed the title cmake: speed up and extend picky compiler options cmake: speed up and extend picky clang/gcc options Apr 16, 2023
@vszakats
Copy link
Member Author

vszakats commented Apr 16, 2023

This is unrelated:

tool_operhlp.c:112:5: warning: Value stored to 'uerr' is never read [deadcode.DeadStores]
    uerr = curl_url_get(uh, CURLUPART_QUERY, &query, 0);
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

@vszakats vszakats closed this in 9c543de Apr 16, 2023
@vszakats vszakats deleted the picky-warnings-1 branch April 16, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants