md(4|5): don't use deprecated iOS functions #11102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 11, 2023
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098 Closes curl#11102
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 11, 2023
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Ref: curl#11098 Closes curl#11102
MarcelRaad
force-pushed
the
md4_deprecated
branch
from
45281f5
to
d580941
Compare
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098 Closes curl#11102
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Bug: curl#11098 Closes curl#11102
MarcelRaad
force-pushed
the
md4_deprecated
branch
from
d580941
to
f51fb35
Compare
bagder
approved these changes
May 12, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098 Closes curl#11102
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Bug: curl#11098 Closes curl#11102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use
*_MIN_REQUIREDinstead of*_MIN_ALLOWEDto check for the minimum macOS and iOS versions. There are other open source projects checking for__MAC_OS_X_VERSION_MIN_ALLOWEDtoo, but__MAC_OS_X_VERSION_MIN_REQUIREDand__IPHONE_OS_VERSION_MIN_REQUIREDseems to be what's currently defined in Apple's AvailabilityInternal.h.