Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md(4|5): don't use deprecated iOS functions #11102

Closed
wants to merge 2 commits into from

Conversation

MarcelRaad
Copy link
Member

Also, use *_MIN_REQUIRED instead of *_MIN_ALLOWED to check for the minimum macOS and iOS versions. There are other open source projects checking for __MAC_OS_X_VERSION_MIN_ALLOWED too, but __MAC_OS_X_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MIN_REQUIRED seems to be what's currently defined in Apple's AvailabilityInternal.h.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request May 11, 2023
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`,
so let's use this here too.

Ref: curl#11098
Closes curl#11102
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request May 11, 2023
They are marked as deprecated in iOS 13.0, which might result in
warnings-as-errors.

Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to
be what's currently used.

Ref: curl#11098
Closes curl#11102
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`,
so let's use this here too.

Ref: curl#11098
Closes curl#11102
They are marked as deprecated in iOS 13.0, which might result in
warnings-as-errors.

Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to
be what's currently used.

Bug: curl#11098
Closes curl#11102
MarcelRaad added a commit that referenced this pull request May 13, 2023
They are marked as deprecated in iOS 13.0, which might result in
warnings-as-errors.

Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to
be what's currently used.

Bug: #11098
Closes #11102
@MarcelRaad MarcelRaad deleted the md4_deprecated branch May 13, 2023 08:07
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`,
so let's use this here too.

Ref: curl#11098
Closes curl#11102
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
They are marked as deprecated in iOS 13.0, which might result in
warnings-as-errors.

Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to
be what's currently used.

Bug: curl#11098
Closes curl#11102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants