HTTP/3, ngtcp2, upload EAGAIN handling #11390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Jun 27, 2023
icing
commented
- refs curl: (95) error while uploading file to nginx with http3 #11389 where IDLE timeouts on upload are reported
- reword ngtcp2 expiry handling to apply to both send+recv calls into the filter
- EAGAIN uploads similar to the recent changes in HTTP/2, e.g. report success only when send data was ACKed.
- HOLD sending of EAGAINed uploads to avoid cpu busy loops
- rename internal function for consistency with HTTP/2 implementation
bneradt
added a commit
to bneradt/proxy-verifier
that referenced
this pull request
Jun 30, 2023
Pull in ngtcp2 curl expiry logic from curl master and the currently unmerged curl/curl#11390.
bneradt
added a commit
to yahoo/proxy-verifier
that referenced
this pull request
Jul 5, 2023
Pull in ngtcp2 curl expiry logic from curl master and the currently unmerged curl/curl#11390.
- refs curl#11389 where IDLE timeouts on upload are reported - reword ngtcp2 expiry handling to apply to both send+recv calls into the filter - EAGAIN uploads similar to the recent changes in HTTP/2, e.g. report success only when send data was ACKed. - HOLD sending of EAGAINed uploads to avoid cpu busy loops - rename internal function for consistency with HTTP/2 implementation
before the ACKing of the upload has been checked. Do send-on-close check only when not handling EGAINed data.
icing
force-pushed
the
h3-upload-blocked-handling
branch
from
f569c88
to
8864cc5
Compare
bagder
approved these changes
Jul 9, 2023
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- refs curl#11389 where IDLE timeouts on upload are reported - reword ngtcp2 expiry handling to apply to both send+recv calls into the filter - EAGAIN uploads similar to the recent changes in HTTP/2, e.g. report success only when send data was ACKed. - HOLD sending of EAGAINed uploads to avoid cpu busy loops - rename internal function for consistency with HTTP/2 implementation Fixes curl#11389 Closes curl#11390
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- refs curl#11389 where IDLE timeouts on upload are reported - reword ngtcp2 expiry handling to apply to both send+recv calls into the filter - EAGAIN uploads similar to the recent changes in HTTP/2, e.g. report success only when send data was ACKed. - HOLD sending of EAGAINed uploads to avoid cpu busy loops - rename internal function for consistency with HTTP/2 implementation Fixes curl#11389 Closes curl#11390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.