Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/3, ngtcp2, upload EAGAIN handling #11390

Closed
wants to merge 3 commits into from
Closed

HTTP/3, ngtcp2, upload EAGAIN handling #11390

wants to merge 3 commits into from

Commits on Jul 9, 2023

  1. HTTP/3, ngtcp2, upload EAGAIN handling 

    - refs curl#11389 where IDLE timeouts on  upload are reported
- reword ngtcp2 expiry handling to apply to both send+recv
  calls into the filter
- EAGAIN uploads similar to the recent changes in HTTP/2, e.g.
  report success only when send data was ACKed.
- HOLD sending of EAGAINed uploads to avoid cpu busy loops
- rename internal function for consistency with HTTP/2
  implementation
    @icing
    icing committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    cc28fc5 View commit details
    Browse the repository at this point in the history

  2. On a EAGAINed send, we might see the response and a stream close 

    before the ACKing of the upload has been checked. Do send-on-close
check only when not handling EGAINed data.
    @icing
    icing committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    1f66d0e View commit details
    Browse the repository at this point in the history

  3. Fix spelling errors detected on review

    @icing
    icing committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    8864cc5 View commit details
    Browse the repository at this point in the history