Add libproxy support #11393
Closed
Add libproxy support #11393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: #977 |
|
also #9068 and my blog post about the dream: https://daniel.haxx.se/blog/2022/08/12/the-dream-of-auto-detecting-proxies/ |
|
Correct and we have taken your review very serious and have addresses them. Volkswagen now takes care of libproxy and it's development. |
bagder
requested changes
Jul 9, 2023
Updated MR initially made by dwmw2
|
Regarding tests: Should it be disabled by default and we add a new action stage for e.g. Linux + libproxy. Or should it be enabled by default? Then i would need to change all actions. |
nmoinvaz
reviewed
Jul 14, 2023
|
Since it still seems libproxy cannot provide a non-blocking API and there has been no movement here in over a month, it seems the time has not yet come for libproxy to be used by curl. Until me meet again, I close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MR initially made by dwmw2