Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manpage fixes #1169

wants to merge 2 commits into from

Manpage fixes #1169

wants to merge 2 commits into from


Copy link

One bug (prototype in CURLOPT_PREQUOTE), and clarifications about not needing to keep strings around to all char* options (apart from POSTFIELDS). I did check the code, and all of the handlers do indeed copy strings if necessary, so the clarifications are correct.

Copy link

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @rousskov and @jay to be potential reviewers.

Copy link

jay commented Dec 21, 2016

+The passed string is copied by the library if necessary, allowing the
+application to overwrite or free it after setting this option.

I think this is too verbose, also I don't know why say "if necessary" everywhere that's just confusing.

Copy link
Contributor Author

I guess the "if necessary" can be confusing. I could make another pass over the lot and update as needed, or I can change the entire thing to something like "The application does not have to keep the string around after setting this option".

@bagder bagder closed this in dbd3793 Jan 13, 2017
@gevaerts gevaerts deleted the manpage_fixes branch May 29, 2018 11:13
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants