secureserver.pl: fix stunnel version parsing#11722
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
- Allow the stunnel minor-version version part to be zero. Prior to this change with the stunnel version scheme of <major>.<minor> if either part was 0 then version parsing would fail, causing secureserver.pl to fail with error "No stunnel", causing tests that use the SSL protocol to be skipped. As a practical matter this bug can only be caused by a minor version part of 0, since the major version part is always greater than 0. Closes #xxxx
Contributor
|
LGTM here too. |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- Allow the stunnel minor-version version part to be zero. Prior to this change with the stunnel version scheme of <major>.<minor> if either part was 0 then version parsing would fail, causing secureserver.pl to fail with error "No stunnel", causing tests that use the SSL protocol to be skipped. As a practical matter this bug can only be caused by a minor-version part of 0, since the major-version part is always greater than 0. Closes curl#11722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change with the stunnel version scheme of
<major>.<minor>if either part was 0 then version parsing would fail, causing secureserver.pl to fail with error "No stunnel", causing tests that use the SSL protocol to be skipped. As a practical matter this bug can only be caused by a minor version part of 0, since the major version part is always greater than 0.Closes #xxxx