New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Support extended attributes when built with cmake #1176

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@jay
Member

jay commented Dec 27, 2016

Several months ago a patch was proposed on the mailing list to support xattr in cmake builds, but it appears to have slipped through the cracks. It is now the commit in this PR. Can a dev familiar with cmake please review?

/cc @sburford @Lekensteyn @snikulov @jzakrzewski

cmake: Support extended attributes when built with cmake
Extended attribute support (--xattr) was omitted when curl was built
with cmake since cmake does not test for and set the HAVE_FSETXATTR
defines.

The configure.ac, configure, make build system is not affected by this
issue.

Closes #XXXX

@jay jay added the cmake label Dec 27, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 27, 2016

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @Lekensteyn to be potential reviewers.

mention-bot commented Dec 27, 2016

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @billhoffman and @Lekensteyn to be potential reviewers.

@Lekensteyn

Changes look good, but see some inline stylistic comments.

Show outdated Hide outdated CMakeLists.txt
Show outdated Hide outdated CMakeLists.txt
@SeanBurford

This comment has been minimized.

Show comment
Hide comment
@SeanBurford

SeanBurford Jan 9, 2017

Thanks for the feedback, I'll prepare an updated patch.

SeanBurford commented Jan 9, 2017

Thanks for the feedback, I'll prepare an updated patch.

@SeanBurford

This comment has been minimized.

Show comment
Hide comment
@SeanBurford

SeanBurford Jan 12, 2017

Thanks again for the feedback. I have attached a shorter patch based on this one that enables xattr support when built using cmake.

cmake-xattr.patch.txt

SeanBurford commented Jan 12, 2017

Thanks again for the feedback. I have attached a shorter patch based on this one that enables xattr support when built using cmake.

cmake-xattr.patch.txt

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jan 12, 2017

Member

cmake-xattr.patch.txt

I've added this patch to the branch as draft2 to make it easier to review

Member

jay commented Jan 12, 2017

cmake-xattr.patch.txt

I've added this patch to the branch as draft2 to make it easier to review

Show outdated Hide outdated CMake/CurlTests.c
@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jan 12, 2017

Member

@Lekensteyn You tool is not broken. It is duplicated block at the end of this file.

Member

snikulov commented Jan 12, 2017

@Lekensteyn You tool is not broken. It is duplicated block at the end of this file.

cmake: Support extended attributes when built with cmake. draft2
Squash me into previous draft.

- Changes to address Peter's review of draft1.
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jan 12, 2017

Member

It is duplicated block at the end of this file.

my fault, patch applied it even though there was no change from the first draft. fixed, please check again

Member

jay commented Jan 12, 2017

It is duplicated block at the end of this file.

my fault, patch applied it even though there was no change from the first draft. fixed, please check again

@Lekensteyn

This comment has been minimized.

Show comment
Hide comment
@Lekensteyn

Lekensteyn Jan 12, 2017

Member

LGTM, let's see what the buildbots say

Member

Lekensteyn commented Jan 12, 2017

LGTM, let's see what the buildbots say

@jay jay closed this in 1c877a0 Feb 1, 2017

@jay jay deleted the jay:cmake_support_xattr branch Feb 1, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Feb 1, 2017

Member

Just landed, thanks guys

Member

jay commented Feb 1, 2017

Just landed, thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment