Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: replace check_library_exists_concat() #12070

Closed
wants to merge 1 commit into from
Closed

cmake: replace check_library_exists_concat() #12070

wants to merge 1 commit into from

Commits on Oct 9, 2023

  1. cmake: delete check_library_exists_concat() 

    The idea of `check_library_exists_concat()` is that it detects an
optional component and adds it to the list of libs that we also use in
subsequent component checks. This caused problems when detecting
components, with unnecessary dependencies that were not yet built.

CMake offers the `CMAKE_REQUIRED_LIBRARIES` variable to set the libs
used for component checks, which we already use in most of the cases.
That left 4 uses of `check_library_exists_concat()`. Only one of these
actually needed the 'concat' feature (ldap/lber).

Delete this function and replace it with standard
`check_library_exists()` and manual management of our `CURL_LIBS`
list we use when linking build targets. And special logic to handle the
ldap/lber case.

(We have a similar function for headers: `check_include_file_concat`.
It works, but problematic for performance reasons and because it hides
the actual headers necessary in `check_symbol_exists()` calls.)

Ref: curl#11537
Fixes curl#11285
Fixes curl#11648
Closes #xxxxx
    @vszakats
    vszakats committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fea9369 View commit details
    Browse the repository at this point in the history