lib: silence `-Wsign-conversion`, tidy-ups, fixes #13481

``` altsvc.c: In function ‘altsvc_add’: altsvc.c:192:18: warning: conversion to ‘int’ from ‘unsigned int’ may change the sign of the result [-Wsign-conversion] 192 | as->prio = prio; | ^~~~ altsvc.c: In function ‘getalnum’: altsvc.c:412:9: warning: conversion to ‘size_t’ {aka ‘long unsigned int’} from ‘long int’ may change the sign of the result [-Wsign-conversion] 412 | len = p - protop; | ^ altsvc.c: In function ‘altsvc_debugtime’: altsvc.c:465:25: warning: conversion to ‘long unsigned int’ from ‘long int’ may change the sign of the result [-Wsign-conversion] 465 | unsigned long val = strtol(timestr, NULL, 10); | ^~~~~~ altsvc.c: In function ‘Curl_altsvc_parse’: altsvc.c:549:19: warning: conversion to ‘size_t’ {aka ‘long unsigned int’} from ‘long int’ may change the sign of the result [-Wsign-conversion] 549 | len = p - hostp; | ^ altsvc.c:627:24: warning: conversion to ‘time_t’ {aka ‘long int’} from ‘long unsigned int’ may change the sign of the result [-Wsign-conversion] 627 | maxage = num; | ^~~ altsvc.c: In function ‘Curl_altsvc_lookup’: altsvc.c:699:18: warning: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] 699 | (versions & as->dst.alpnid)) { | ^ ``` Ref: https://github.com/curl/curl/actions/runs/8819398779/job/24210519501#step:30:25

win32: ``` 177 | vals.keepalivetime = optval; | ~ ^~~~~~ /home/runner/work/curl/curl/curl/lib/cf-socket.c:180:30: error: implicit conversion changes signedness: 'int' to 'u_long' (aka 'unsigned long') [-Werror,-Wsign-conversion] 180 | vals.keepaliveinterval = optval; | ~ ^~~~~~ ``` Ref: https://github.com/curl/curl/actions/runs/8862225447/job/24334941063?pr=13489#step:3:6125

Linux 32-bit gcc: ``` cookie.c: In function ‘cookie_hash_domain’: cookie.c:266:7: error: conversion to ‘size_t’ {aka ‘unsigned int’} from ‘unsigned int’ may change the sign of the result [-Werror=sign-conversion] 266 | h ^= (size_t)Curl_raw_toupper(*domain++); | ^~ ``` Ref: https://github.com/curl/curl/actions/runs/8859933866/job/24330206389?pr=13489#step:6:90 temp: ``` cookie.c:266:11: error: conversion to ‘size_t’ {aka ‘unsigned int’} from ‘unsigned int’ may change the sign of the result [-Werror=sign-conversion] 266 | h = h ^ (size_t)Curl_raw_toupper(*domain++); | ^ ``` Ref: https://github.com/curl/curl/actions/runs/8861448062/job/24333315928?pr=13489#step:6:79

``` inet_ntop.h:36:34: error: conversion to 'size_t' {aka 'long long unsigned int'} from 'int' may change the sign of the result [-Werror=sign-conversion] libtool: compile: x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -fvisibility=hidden -Werror-implicit-function-declaration -g -O0 -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wbad-function-cast -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wstrict-aliasing=3 -Wattributes -Wdiv-by-zero -Wformat-security -Wmissing-field-initializers -Wmissing-noreturn -Wunreachable-code -Wunused-parameter -Wpragmas -Wredundant-decls -Wcast-align -Waddress -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wtrampolines -Wsign-conversion -Wvla -ftree-vrp -Wno-pedantic-ms-format -Wdouble-promotion -Wformat=2 -Warray-bounds=2 -Wshift-negative-value -Wshift-overflow=2 -Wnull-dereference -fdelete-null-pointer-checks -Wduplicated-cond -Wunused-const-variable -Wduplicated-branches -Wrestrict -Walloc-zero -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough -Warith-conversion -Wenum-conversion -Wno-system-headers -Werror -pedantic-errors -MT libcurl_la-hostasyn.lo -MD -MP -MF .deps/libcurl_la-hostasyn.Tpo -c hostasyn.c -DDLL_EXPORT -DPIC -o .libs/libcurl_la-hostasyn.o 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) mv -f .deps/libcurl_la-hmac.Tpo .deps/libcurl_la-hmac.Plo hostip.c:144:11: note: in expansion of macro 'Curl_inet_ntop' 144 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr4, | ^~~~~~~~~~~~~~ /bin/sh ../libtool --tag=CC --mode=compile x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -fvisibility=hidden -Werror-implicit-function-declaration -g -O0 -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wbad-function-cast -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wstrict-aliasing=3 -Wattributes -Wdiv-by-zero -Wformat-security -Wmissing-field-initializers -Wmissing-noreturn -Wunreachable-code -Wunused-parameter -Wpragmas -Wredundant-decls -Wcast-align -Waddress -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wtrampolines -Wsign-conversion -Wvla -ftree-vrp -Wno-pedantic-ms-format -Wdouble-promotion -Wformat=2 -Warray-bounds=2 -Wshift-negative-value -Wshift-overflow=2 -Wnull-dereference -fdelete-null-pointer-checks -Wduplicated-cond -Wunused-const-variable -Wduplicated-branches -Wrestrict -Walloc-zero -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough -Warith-conversion -Wenum-conversion -Wno-system-headers -Werror -pedantic-errors -MT libcurl_la-hostip.lo -MD -MP -MF .deps/libcurl_la-hostip.Tpo -c -o libcurl_la-hostip.lo `test -f 'hostip.c' || echo './'`hostip.c inet_ntop.h:36:34: error: conversion to 'size_t' {aka 'long long unsigned int'} from 'int' may change the sign of the result [-Werror=sign-conversion] libtool: compile: x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -fvisibility=hidden -Werror-implicit-function-declaration -g -O0 -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wbad-function-cast -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wstrict-aliasing=3 -Wattributes -Wdiv-by-zero -Wformat-security -Wmissing-field-initializers -Wmissing-noreturn -Wunreachable-code -Wunused-parameter -Wpragmas -Wredundant-decls -Wcast-align -Waddress -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wtrampolines -Wsign-conversion -Wvla -ftree-vrp -Wno-pedantic-ms-format -Wdouble-promotion -Wformat=2 -Warray-bounds=2 -Wshift-negative-value -Wshift-overflow=2 -Wnull-dereference -fdelete-null-pointer-checks -Wduplicated-cond -Wunused-const-variable -Wduplicated-branches -Wrestrict -Walloc-zero -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough -Warith-conversion -Wenum-conversion -Wno-system-headers -Werror -pedantic-errors -MT libcurl_la-hostip.lo -MD -MP -MF .deps/libcurl_la-hostip.Tpo -c hostip.c -DDLL_EXPORT -DPIC -o .libs/libcurl_la-hostip.o 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) libtool: compile: x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -fvisibility=hidden -Werror-implicit-function-declaration -g -O0 -pedantic -Wall -W -Wpointer-arith -Wwrite-strings -Wunused -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wbad-function-cast -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wstrict-aliasing=3 -Wattributes -Wdiv-by-zero -Wformat-security -Wmissing-field-initializers -Wmissing-noreturn -Wunreachable-code -Wunused-parameter -Wpragmas -Wredundant-decls -Wcast-align -Waddress -Wtype-limits -Wold-style-declaration -Wmissing-parameter-type -Wempty-body -Wclobbered -Wignored-qualifiers -Wconversion -Wtrampolines -Wsign-conversion -Wvla -ftree-vrp -Wno-pedantic-ms-format -Wdouble-promotion -Wformat=2 -Warray-bounds=2 -Wshift-negative-value -Wshift-overflow=2 -Wnull-dereference -fdelete-null-pointer-checks -Wduplicated-cond -Wunused-const-variable -Wduplicated-branches -Wrestrict -Walloc-zero -Wformat-overflow=2 -Wformat-truncation=2 -Wimplicit-fallthrough -Warith-conversion -Wenum-conversion -Wno-system-headers -Werror -pedantic-errors -MT libcurl_la-hostasyn.lo -MD -MP -MF .deps/libcurl_la-hostasyn.Tpo -c hostasyn.c -o libcurl_la-hostasyn.o >/dev/null 2>&1 hostip.c:152:11: note: in expansion of macro 'Curl_inet_ntop' mv -f .deps/libcurl_la-hostasyn.Tpo .deps/libcurl_la-hostasyn.Plo 152 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr6, make[2]: Leaving directory '/c/__w/1/s/lib' | ^~~~~~~~~~~~~~ ``` ``` In file included from /home/runner/work/curl/curl/curl/_x64-win-ucrt-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:178: /home/runner/work/curl/curl/curl/lib/hostip.c:144:11: error: implicit conversion changes signedness: 'curl_socklen_t' (aka 'int') to 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-conversion] 144 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr4, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 145 | buf, (size_t)bufsize); | ~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/curl/curl/curl/lib/inet_ntop.h:36:34: note: expanded from macro 'Curl_inet_ntop' 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) | ~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ In file included from /home/runner/work/curl/curl/curl/_x64-win-ucrt-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:178: /home/runner/work/curl/curl/curl/lib/hostip.c:152:11: error: implicit conversion changes signedness: 'curl_socklen_t' (aka 'int') to 'size_t' (aka 'unsigned long long') [-Werror,-Wsign-conversion] 152 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr6, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 153 | buf, (size_t)bufsize); | ~~~~~~~~~~~~~~~~~~~~~ /home/runner/work/curl/curl/curl/lib/inet_ntop.h:36:34: note: expanded from macro 'Curl_inet_ntop' 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) | ~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ ``` ``` hostip.c: In function 'Curl_printable_address': inet_ntop.h:36:34: error: conversion to 'size_t' {aka 'long long unsigned int'} from 'int' may change the sign of the result [-Werror=sign-conversion] 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) hostip.c:144:11: note: in expansion of macro 'Curl_inet_ntop' 144 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr4, | ^~~~~~~~~~~~~~ inet_ntop.h:36:34: error: conversion to 'size_t' {aka 'long long unsigned int'} from 'int' may change the sign of the result [-Werror=sign-conversion] 36 | inet_ntop(af, addr, buf, (curl_socklen_t)size) hostip.c:152:11: note: in expansion of macro 'Curl_inet_ntop' 152 | (void)Curl_inet_ntop(ai->ai_family, (const void *)ipaddr6, | ^~~~~~~~~~~~~~ ```

``` setopt.c: In function ‘Curl_vsetopt’: setopt.c:156:38: error: conversion to ‘long unsigned int’ from ‘long int’ may change the sign of the result [-Werror=sign-conversion] 156 | #define C_SSLVERSION_MAX_VALUE(x) (x & 0xffff0000) | ^ setopt.c:477:21: note: in expansion of macro ‘C_SSLVERSION_MAX_VALUE’ 477 | version_max = C_SSLVERSION_MAX_VALUE(arg); | ^~~~~~~~~~~~~~~~~~~~~~ setopt.c:156:35: error: conversion to ‘long int’ from ‘long unsigned int’ may change the sign of the result [-Werror=sign-conversion] 156 | #define C_SSLVERSION_MAX_VALUE(x) (x & 0xffff0000) | ^ setopt.c:477:21: note: in expansion of macro ‘C_SSLVERSION_MAX_VALUE’ 477 | version_max = C_SSLVERSION_MAX_VALUE(arg); | ^~~~~~~~~~~~~~~~~~~~~~ ``` Ref: https://github.com/curl/curl/actions/runs/8862048067/job/24334557085?pr=13489

also fixup (32-bit i686-linux-gnu-gcc-11) ``` hash.c:282:7: error: conversion to ‘size_t’ {aka ‘unsigned int’} from ‘unsigned int’ may change the sign of the result [-Werror=sign-conversion] 282 | h ^= (size_t)*key_str++; | ^~ ``` Ref: https://github.com/curl/curl/actions/runs/8862007379/job/24334479063?pr=13489#step:6:235 Also address FIXMEs Rebased on fixes cc907e8 curl#13502

``` /__w/curl/curl/lib/headers.c:57:15: error: conversion to 'unsigned int' from 'int' may change the sign of the result [-Werror=sign-conversion] h->origin = hs->type | (1<<27); ^~ ``` Ref: https://github.com/curl/curl/actions/runs/8859933860/job/24330205818?pr=13489#step:5:440

temp: ``` /__w/curl/curl/lib/krb5.c:528:22: error: conversion to 'uint32_t {aka unsigned int}' from 'int' may change the sign of the result [-Werror=sign-conversion] len = (int)ntohl((unsigned long)len); ^ /__w/curl/curl/lib/krb5.c: In function 'do_sec_send': /__w/curl/curl/lib/krb5.c:651:30: error: conversion to 'uint32_t {aka unsigned int}' from 'int' may change the sign of the result [-Werror=sign-conversion] htonl_bytes = (int)htonl((unsigned long)bytes); ^ ``` Ref: https://github.com/curl/curl/actions/runs/8862697118/job/24335936723?pr=13489#step:7:132

``` sws.c:1308:21: warning: implicit conversion changes signedness: 'enum (unnamed enum at sws.c:71:8)' to 'int' [-Wsign-conversion] serverfd = socket(socket_domain, SOCK_STREAM, 0); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../lib/memdebug.h:140:18: note: expanded from macro 'socket' curl_dbg_socket(domain, type, protocol, __LINE__, __FILE__) ~~~~~~~~~~~~~~~ ^~~~~~ clang -DHAVE_CONFIG_H -I../../include -I../../lib -I../../lib -isystem /home/runner/bearssl/include -Qunused-arguments -g -O0 -pedantic -Wall -Wextra -Wpointer-arith -Wwrite-strings -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wfloat-equal -Wsign-compare -Wno-multichar -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wcast-align -Wno-system-headers -Wshorten-64-to-32 -Wunused -Waddress -Wattributes -Wbad-function-cast -Wconversion -Wdiv-by-zero -Wformat-security -Wempty-body -Wmissing-field-initializers -Wmissing-noreturn -Wold-style-definition -Wredundant-decls -Wtype-limits -Wunreachable-code -Wunused-parameter -Wignored-qualifiers -Wvla -Wsign-conversion -Wshift-sign-overflow -Wlanguage-extension-token -Wformat=2 -Wenum-conversion -Wsometimes-uninitialized -Wmissing-variable-declarations -Wheader-guard -Wunused-const-variable -Wpragmas -Wunreachable-code-break -Wdouble-promotion -Wcomma -Wassign-enum -Wextra-semi-stmt -Wimplicit-fallthrough -Wno-pointer-bool-conversion -MT ../../lib/tftpd-nonblock.o -MD -MP -MF ../../lib/.deps/tftpd-nonblock.Tpo -c -o ../../lib/tftpd-nonblock.o `test -f '../../lib/nonblock.c' || echo './'`../../lib/nonblock.c sws.c:2136:17: warning: implicit conversion changes signedness: 'enum (unnamed enum at sws.c:71:8)' to 'int' [-Wsign-conversion] sock = socket(socket_domain, SOCK_STREAM, 0); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../lib/memdebug.h:140:18: note: expanded from macro 'socket' curl_dbg_socket(domain, type, protocol, __LINE__, __FILE__) ~~~~~~~~~~~~~~~ ^~~~~~ 2 warnings generated. ``` Ref: https://github.com/curl/curl/actions/runs/8866821106/job/24344717997#step:34:174

Seen on Alpine MUSL. ``` multi.c:1201:9: error: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Werror=sign-conversion] 1201 | FD_SET(ps.sockets[i], read_fd_set); | ^~~~~~ multi.c:1201:9: error: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Werror=sign-conversion] multi.c:1203:9: error: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Werror=sign-conversion] 1203 | FD_SET(ps.sockets[i], write_fd_set); | ^~~~~~ multi.c:1203:9: error: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Werror=sign-conversion] ``` Ref: https://github.com/curl/curl/actions/runs/8867959370/job/24347027402?pr=13489#step:31:373

``` ../../lib/tftp.c: In function 'tftp_send_first': ../../lib/tftp.c:531:46: error: conversion to 'socklen_t' {aka 'int'} from 'unsigned int' may change the sign of the result [-Werror=sign-conversion] 531 | data->conn->remote_addr->addrlen); | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ ../../lib/tftp.c: In function 'tftp_connect': ../../lib/tftp.c:1036:36: error: conversion to 'socklen_t' {aka 'int'} from 'unsigned int' may change the sign of the result [-Werror=sign-conversion] 1036 | conn->remote_addr->addrlen); | ~~~~~~~~~~~~~~~~~^~~~~~~~~ ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/49706723/job/pxrgsssfmunjk2o9#L1212

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: silence `-Wsign-conversion`, tidy-ups, fixes #13481

lib: silence `-Wsign-conversion`, tidy-ups, fixes #13481

Commits on Apr 30, 2024

lib: silence -Wsign-conversion, tidy-ups, fixes #13481

lib: silence -Wsign-conversion, tidy-ups, fixes #13481

Commits on Apr 30, 2024

lib: silence `-Wsign-conversion`, tidy-ups, fixes #13481

lib: silence `-Wsign-conversion`, tidy-ups, fixes #13481