cmake: FindNGHTTP2 add static lib name to find_library call - #13495
Closed
fuzzard wants to merge 1 commit into
Closed
cmake: FindNGHTTP2 add static lib name to find_library call#13495fuzzard wants to merge 1 commit into
fuzzard wants to merge 1 commit into
Conversation
Adds the static library name, nghttp2_static as a name to search.
vszakats
changed the title
vszakats
approved these changes
Apr 29, 2024
Member
Member
|
@vszakats remember to add |
Member
|
@bagder I will do, sorry for missing this. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the static library name, nghttp2_static as a name to search.
This provides cmake parity with the winbuild Makefile.vc allowing the cmake build to find and allow the link to static nghttp2 library
curl/winbuild/Makefile.vc
Lines 147 to 158 in dfdd978