cmake: Fix build with GCC 14 + MinGW - #13578
Closed
orgads wants to merge 1 commit into
Closed
Conversation
The function signature has had u_long flags since ever. This is how it
is defined in the documentation, and implemented in MinGW.
The code that uses ioctlsocket in nonblock.c also has unsigned long.
Error:
CurlTests.c:275:41: error: passing argument 3 of 'ioctlsocket' from incompatible pointer type [-Wincompatible-pointer-types]
275 | if(0 != ioctlsocket(0, FIONBIO, &flags))
| ^~~~~~
| |
| int *
In file included from CurlTests.c:266:
/opt/mxe/usr/i686-w64-mingw32.static/include/winsock2.h:1007:76: note: expected 'u_long *' {aka 'long unsigned int *'} but argument is of type 'int *'
1007 | WINSOCK_API_LINKAGE int WSAAPI ioctlsocket(SOCKET s,__LONG32 cmd,u_long *argp);
| ~~~~~~~~^~~~
Member
|
Nice catch! It's curious this test is repeated twice in |
vszakats
approved these changes
May 11, 2024
Member
|
Thanks, merged! |
6 tasks
semeaj
added a commit
to semeaj/jak-project
that referenced
this pull request
Jul 22, 2026
Replace the curl-8_3_0 vendored tree with the curl-8_21_0 tag tree. Clang 22 promotes -Wincompatible-pointer-types to a hard error in C, which broke the HAVE_IOCTLSOCKET_FIONBIO configure probe in the old tree (int* passed where ioctlsocket() wants u_long*) and stopped Windows builds at the deliberate #error in lib/nonblock.c. Upstream fixed the probe in curl 8.8.0 (curl/curl#13578), so vendoring the current release picks that up along with two years of fixes. Adjustments forced by the version jump: - curl 8.15 removed the native macOS Secure Transport backend (CURL_USE_SECTRANSP), so macOS now builds curl against OpenSSL like linux; the macOS workflows install openssl@3 and export OPENSSL_ROOT_DIR, and the macOS setup docs cover the same - CURL_BROTLI/CURL_ZSTD switched to AUTO-detection in curl 8.10; pinned OFF to keep the old no-compression behavior - curl's new BUILD_EXAMPLES cache option (default ON) leaked into discord-rpc's identically named option and broke configure; pinned OFF ahead of the third-party subdirectories Refs open-goal#8
semeaj
added a commit
to semeaj/jak-project
that referenced
this pull request
Jul 23, 2026
Replace the curl-8_3_0 vendored tree with the curl-8_21_0 tag tree. Clang 22 promotes -Wincompatible-pointer-types to a hard error in C, which broke the HAVE_IOCTLSOCKET_FIONBIO configure probe in the old tree (int* passed where ioctlsocket() wants u_long*) and stopped Windows builds at the deliberate #error in lib/nonblock.c. Upstream fixed the probe in curl 8.8.0 (curl/curl#13578), so vendoring the current release picks that up along with two years of fixes. Adjustments forced by the version jump: - curl 8.15 removed the native macOS Secure Transport backend (CURL_USE_SECTRANSP), so macOS now builds curl against OpenSSL like linux; the macOS workflows install openssl@3 and export OPENSSL_ROOT_DIR, and the macOS setup docs cover the same - CURL_BROTLI/CURL_ZSTD switched to AUTO-detection in curl 8.10; pinned OFF to keep the old no-compression behavior - curl's new BUILD_EXAMPLES cache option (default ON) leaked into discord-rpc's identically named option and broke configure; pinned OFF ahead of the third-party subdirectories Refs open-goal#8
xTVaser
pushed a commit
to open-goal/jak-project
that referenced
this pull request
Jul 27, 2026
…configure loop) (#4355) ## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in #3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function signature has had u_long flags since ever. This is how it is defined in the documentation, and implemented in MinGW.
The code that uses ioctlsocket in nonblock.c also has unsigned long.
Error:
Closes #13578