New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: use the variable MAKE for recursive calls #1366

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@majstar
Contributor

majstar commented Mar 28, 2017

Hello.
According to the manual of GNU make, recursive make commands should always use the variable MAKE, not the explicit command name 'make'. The value of this variable is the file name with which make was invoked. Using of explicit 'make' command for recursive calls may cause problems when non-default make utility is used (not the /usr/bin/make).

@mention-bot

This comment has been minimized.

mention-bot commented Mar 28, 2017

@majstar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @yangtse to be potential reviewers.

@majstar

This comment has been minimized.

Contributor

majstar commented Mar 28, 2017

I am sorry for a malformed commit message.

@majstar majstar changed the title from make: use the variable MAKE: command not found for recursive calls to make: use the variable MAKE for recursive calls Mar 28, 2017

@bagder

bagder approved these changes Mar 29, 2017

@bagder bagder closed this in d1ddda7 Mar 29, 2017

@bagder

This comment has been minimized.

Member

bagder commented Mar 29, 2017

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.