Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: detect and bail out early on parameter integer overflows #1736

Closed
wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 6, 2017

Make the number parser aware of the maximum limit curl accepts for a
value and return an error immediately if larger, instead of running an
integer overflow later.

Fixes #1730

Make the number parser aware of the maximum limit curl accepts for a
value and return an error immediately if larger, instead of running an
integer overflow later.

Fixes #1730
@mention-bot
Copy link

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @captain-caveman2k and @kdudka to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 75.356% when pulling f1c26ef on bagder/curl-integer-overflow-1730 into d6c8def on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 75.33% when pulling 2f97b7f on bagder/curl-integer-overflow-1730 into d6c8def on master.

@bagder bagder closed this in 5c7455f Aug 7, 2017
@bagder bagder deleted the bagder/curl-integer-overflow-1730 branch August 7, 2017 08:03
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants