Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Sequel to #1187 (comment)
The issue is essentially the same as in the opening post of #1187 (comment)
PHP uses the backslash format for file:// URL's. This PR aims to include URL's like file://c:\some\path\curl.out as well.
I have read the remark in #1187 (comment) that backslashes in URL's are forbidden by both [RFC1738] and [RFC3986]. Hence, it would be better to fix the issue in PHP. @weltling intends to do that for the actively maintained PHP versions (PHP 7.1 and PHP 7.2), but the fix will not be backported to versions like PHP 5.6 (which will receive security fixes only). If this PR is merged users of PHP 5.6 can also enjoy the enhancements of the latest curl version.
I will be honest, I wasn't sure how to approach the issue of backslashes when I submitted #2110.
I think 3 and 4 above are enough justification for accepting the patch.
... as in "file://c:\some\path\curl.out" Reviewed-by: Matthew Kerwin Closes curl#2154