Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upopenssl: retrieve reported libressl version at runtime #2425
Conversation
lib/vtls/openssl.c
Outdated
| #ifdef OPENSSL_IS_BORINGSSL | ||
| return snprintf(buffer, size, OSSL_PACKAGE); | ||
| /* no version extraction method known */ | ||
| #elif LIBRESSL_VERSION_NUMBER |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Note that this causes a CI error on the libressl build on macOS |
This comment has been minimized.
This comment has been minimized.
|
Rebase and try again? |
This comment has been minimized.
This comment has been minimized.
|
Is this something you still intend to work on? |
This comment has been minimized.
This comment has been minimized.
|
The work on this has clearly stopped so let's close this for now and we can reopen if the work resumes! |
Prior to this change the LibreSSL version was determined at compile-time. Ref: https://man.openbsd.org/OPENSSL_VERSION_NUMBER.3 Closes #2425
jay
added a commit
to jay/curl
that referenced
this pull request
Nov 27, 2019
jay
force-pushed the
jay:ossl_fix_libressl_ver
branch
2 times, most recently
from
0c17eef
to
041e867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jay commentedMar 24, 2018
LibreSSL added a OpenSSL_version_num that always returns 0x020000000L.
That conflicted with the workaround function we were using to return the
compile-time LibreSSL actual version. This change removes that
workaround in favor of extracting the actual version at runtime.
Fixes #2319