Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: retrieve reported libressl version at runtime #2425

Closed
wants to merge 1 commit into from
Closed

openssl: retrieve reported libressl version at runtime #2425

wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

jay commented Mar 24, 2018

LibreSSL added a OpenSSL_version_num that always returns 0x020000000L.
That conflicted with the workaround function we were using to return the
compile-time LibreSSL actual version. This change removes that
workaround in favor of extracting the actual version at runtime.

Fixes #2319
@jay jay added the SSL/TLS label Mar 24, 2018
@jay jay mentioned this pull request Mar 24, 2018
Closed
@bagder
bagder reviewed Mar 24, 2018
View changes
lib/vtls/openssl.c Outdated
#ifdef OPENSSL_IS_BORINGSSL
return snprintf(buffer, size, OSSL_PACKAGE);
/* no version extraction method known */
#elif LIBRESSL_VERSION_NUMBER

This comment has been minimized.

Sign in to view
Copy link
@bagder

bagder Mar 24, 2018

Member

#elif defined(LIBRESSL_VERSION_NUMBER)

This comment has been minimized.

Sign in to view
Copy link
@jay

jay Mar 24, 2018

Author Member

Thanks, fixed
@jay jay force-pushed the jay:ossl_fix_libressl_ver branch from 667e1f3 to 58bc1f5 Mar 24, 2018
@bagder
Copy link
Member

bagder commented Mar 30, 2018

Note that this causes a CI error on the libressl build on macOS
@bagder
Copy link
Member

bagder commented Apr 6, 2018

Rebase and try again?
@bagder
Copy link
Member

bagder commented May 30, 2018

Is this something you still intend to work on?
@bagder
Copy link
Member

bagder commented Jun 29, 2018

The work on this has clearly stopped so let's close this for now and we can reopen if the work resumes!
@bagder bagder closed this Jun 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2018
@curl curl unlocked this conversation Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2019
@jay jay reopened this Nov 25, 2019
@curl curl unlocked this conversation Nov 25, 2019
@jay jay force-pushed the jay:ossl_fix_libressl_ver branch from 58bc1f5 to 08b5ab8 Nov 25, 2019
jay added a commit to jay/curl that referenced this pull request Nov 26, 2019
@jay
openssl: retrieve reported LibreSSL version at runtime
Loading status checks…
4495f69 
Prior to this change the LibreSSL version was determined at
compile-time.

Closes curl#2425
@jay jay force-pushed the jay:ossl_fix_libressl_ver branch from 08b5ab8 to 4495f69 Nov 26, 2019
@jay
openssl: retrieve reported LibreSSL version at runtime
Loading status checks…
041e867 
Prior to this change the LibreSSL version was determined at
compile-time.

Ref: https://man.openbsd.org/OPENSSL_VERSION_NUMBER.3

Closes #2425
jay added a commit to jay/curl that referenced this pull request Nov 27, 2019
@jay
openssl: retrieve reported LibreSSL version at runtime
Loading status checks…
0c17eef 
Prior to this change the LibreSSL version was determined at
compile-time.

Closes curl#2425
@jay jay force-pushed the jay:ossl_fix_libressl_ver branch 2 times, most recently from 0c17eef to 041e867 Nov 27, 2019
@jay jay closed this in 0436d44 Dec 2, 2019
@jay jay deleted the jay:ossl_fix_libressl_ver branch Dec 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
SSL/TLS
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

libressl: static declaration of 'OpenSSL_version_num'
2 participants
@jay @bagder
You can’t perform that action at this time.