openssl: retrieve reported libressl version at runtime #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Mar 24, 2018
lib/vtls/openssl.c
Outdated
| #ifdef OPENSSL_IS_BORINGSSL | ||
| return snprintf(buffer, size, OSSL_PACKAGE); | ||
| /* no version extraction method known */ | ||
| #elif LIBRESSL_VERSION_NUMBER |
There was a problem hiding this comment.
#elif defined(LIBRESSL_VERSION_NUMBER)
jay
force-pushed
the
ossl_fix_libressl_ver
branch
from
667e1f3 to
58bc1f5
Compare
|
Note that this causes a CI error on the libressl build on macOS |
|
Rebase and try again? |
|
Is this something you still intend to work on? |
|
The work on this has clearly stopped so let's close this for now and we can reopen if the work resumes! |
jay
force-pushed
the
ossl_fix_libressl_ver
branch
from
58bc1f5 to
08b5ab8
Compare
jay
force-pushed
the
ossl_fix_libressl_ver
branch
from
08b5ab8 to
4495f69
Compare
Prior to this change the LibreSSL version was determined at compile-time. Ref: https://man.openbsd.org/OPENSSL_VERSION_NUMBER.3 Closes curl#2425
jay
force-pushed
the
ossl_fix_libressl_ver
branch
2 times, most recently
from
0c17eef to
041e867
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibreSSL added a OpenSSL_version_num that always returns 0x020000000L.
That conflicted with the workaround function we were using to return the
compile-time LibreSSL actual version. This change removes that
workaround in favor of extracting the actual version at runtime.
Fixes #2319