url: use the URL API internally as well #3017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/urlapi-internal
branch
2 times, most recently
from
7cefdff
to
b401689
Compare
bagder
added a commit
that referenced
this pull request
Sep 20, 2018
... to make it a truly unified URL parser. Closes #3017
... to make it a truly unified URL parser. Closes #3017
bagder
force-pushed
the
bagder/urlapi-internal
branch
from
dba4818
to
0e7f879
Compare
|
I intend to rebase, squash and merge this PR soon. All CI builds are now green. I suspect this might introduce some edge case regressions, but I also think it is worth that risk to get a unified and more solid URL parsing all over. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make it a truly unified URL parser.
Reduces all form of URL parsing that isn't using the unified URL parser.