New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fixed path used for docs/tests generation #3056

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@snikulov
Member

snikulov commented Sep 28, 2018

How to reproduce:
Add curl as subproject using add_subdirectory(curl) (I've used cpr for test)

Error:
Scanning dependencies of target generate-curl.1
[ 16%] Generating ../../../../docs/curl.1
/bin/sh: .../cpr/build/docs/curl.1: No such file or directory
make[2]: *** [opt/curl/docs/cmdline-opts/CMakeFiles/generate-curl.1.dir/build.make:281: docs/curl.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:1282: opt/curl/docs/cmdline-opts/CMakeFiles/generate-curl.1.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Thanks to @chenchuanyin for bringing this out and providing the fix.

Closes: #2906

@snikulov snikulov added the cmake label Sep 28, 2018

@snikulov

This comment has been minimized.

Member

snikulov commented Sep 28, 2018

@bagder, should I merge? Coverails coverage decreased because of 7ae78fe .

@bagder

This comment has been minimized.

Member

bagder commented Sep 28, 2018

Go ahead, that coverage thing is a bit silly at times...

@snikulov snikulov merged commit f8215f8 into curl:master Sep 28, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-1.3%) to 72.241%
Details
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment