cmake: fixed path used for docs/tests generation#3056
Merged
snikulov merged 1 commit intocurl:masterfrom Sep 28, 2018
Merged
Conversation
…through add_subdicectory(...)
jzakrzewski
approved these changes
Sep 28, 2018
Contributor
Author
Member
|
Go ahead, that coverage thing is a bit silly at times... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Add curl as subproject using
add_subdirectory(curl)(I've used cpr for test)Error:
Scanning dependencies of target generate-curl.1
[ 16%] Generating ../../../../docs/curl.1
/bin/sh: .../cpr/build/docs/curl.1: No such file or directory
make[2]: *** [opt/curl/docs/cmdline-opts/CMakeFiles/generate-curl.1.dir/build.make:281: docs/curl.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:1282: opt/curl/docs/cmdline-opts/CMakeFiles/generate-curl.1.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Thanks to @chenchuanyin for bringing this out and providing the fix.
Closes: #2906