New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timediff: fix math for unsigned time_t #3449

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bagder
Copy link
Member

bagder commented Jan 8, 2019

@jay

This comment has been minimized.

Copy link
Member

jay commented Jan 8, 2019

I don't see where he's getting that about time_t being 32-bit unsigned for Windows. He just says "I've confirmed..." and stuff like that but doesn't say what compiler he's using that does that. I can't think of a compiler that uses 32-bit unsigned time_t for Windows.

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jan 8, 2019

I totally agree. But there are other systems with unsigned time_t and this fix is probably good for them (in addition).

@bagder bagder closed this in 1a93153 Jan 9, 2019

@bagder bagder deleted the bagder/timediff-unsigned-time_t branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment