Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional libraries to check for LDAP support #3596

Closed
wants to merge 1 commit into from
Closed

add additional libraries to check for LDAP support #3596

wants to merge 1 commit into from

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Feb 21, 2019

A PR to resolve issue-3595.

On AIX additional libraries (-lcrypt and -lssl) must be provided for openldap to link properly

Fixes #3595

@aixtools
Copy link
Contributor Author

aixtools commented Feb 21, 2019

FYI: with this patch I get:
configure: Configured to build curl/libcurl:

  Host setup:       powerpc-ibm-aix5.3.7.0
  Install prefix:   /opt
  Compiler:         xlc_r
   CFLAGS:          -I/opt/include -O2 -qmaxmem=-1 -qarch=pwr5
   CPPFLAGS:        -I/opt/include -qthreaded -qnoansialias -qhalt=e -I/opt/include -I/opt/include
   LDFLAGS:         -L/opt/lib -L/opt/lib
   LIBS:            -lssh2 -lssh2 -lssl -lcrypto -lldap -llber -lssl -lcrypto -lz

  curl version:     7.64.0
  SSL support:      enabled (OpenSSL)
  SSH support:      enabled (libSSH2)
  zlib support:     enabled
  brotli support:   no      (--with-brotli)
  GSS-API support:  no      (--with-gssapi)
  TLS-SRP support:  enabled
  resolver:         POSIX threaded
  IPv6 support:     enabled
  Unix sockets support: enabled
  IDN support:      no      (--with-{libidn2,winidn})
  Build libcurl:    Shared=yes, Static=no
  Built-in manual:  enabled
  --libcurl option: enabled (--disable-libcurl-option)
  Verbose errors:   enabled (--disable-verbose)
  Code coverage:    disabled
  SSPI support:     no      (--enable-sspi)
  ca cert bundle:   /var/ssl/cacert.pem   (warning: certs not found)
  ca cert path:     no
  ca fallback:      no
  LDAP support:     enabled (OpenLDAP)
  LDAPS support:    enabled
  RTSP support:     enabled
  RTMP support:     no      (--with-librtmp)
  metalink support: no      (--with-libmetalink)
  PSL support:      no      (libpsl not found)
  HTTP2 support:    disabled (--with-nghttp2)
  Protocols:        DICT FILE FTP FTPS GOPHER HTTP HTTPS IMAP IMAPS LDAP LDAPS POP3 POP3S RTSP SCP SFTP SMB SMBS SMTP SMTPS TELNET TFTP

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this doesn't hurt to add as we've already gone down that rabbit hole, but generally I don't think it worth pursuing attempts to link with static libs in configure.

@bagder bagder added the build label Feb 21, 2019
@bagder
Copy link
Member

bagder commented Feb 21, 2019

LIBS: -lssh2 -lssh2 -lssl -lcrypto -lldap -llber -lssl -lcrypto -lz

So you now got -lssl -lcrypto added twice on the command line! So perhaps the fix could instead have been to prepend the LDAP libraries to the existing LIBS instead of appending them in the loop that tests them?

@jay
Copy link
Member

jay commented Feb 21, 2019

I suppose this doesn't hurt to add as we've already gone down that rabbit hole

Why go deeper and who's to say ssl and crypto will be available

Nevermind I didn't check what was happening, I thought it was going to be required which it's not.

@aixtools
Copy link
Contributor Author

aixtools commented Feb 22, 2019

Prepending them should work, but that would take much more "thinking" on my part. This is pragmatic (or least invasive).

In any case - I hope it helps!

@jay jay closed this in 66637b4 Feb 25, 2019
@jay
Copy link
Member

jay commented Feb 25, 2019

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

AIX does not find LDAP libraries when working with openldap
3 participants