Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket handling and WIN32 WSACleanup fixes #3663

Closed
wants to merge 3 commits into from
Closed

socket handling and WIN32 WSACleanup fixes #3663

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1572de8
This commit corrects a missing call to close() against sockfd and add…
Mar 11, 2019
943fb74
Add missing WSACleanup() call, per Microsoft's Winsock2 documentation:
Mar 11, 2019
a7a9b2e
Removed trailing whitespace, as requested by Daniel Stenberg.
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion docs/examples/externalsocket.c
View file
Open in desktop
Expand Up @@ -124,8 +124,10 @@ int main(void)
servaddr.sin_port = htons(PORTNUM);

servaddr.sin_addr.s_addr = inet_addr(IPADDR);
if(INADDR_NONE == servaddr.sin_addr.s_addr)
if(INADDR_NONE == servaddr.sin_addr.s_addr) {
close(sockfd);
return 2;
}

if(connect(sockfd, (struct sockaddr *) &servaddr, sizeof(servaddr)) ==
-1) {
Expand Down Expand Up @@ -157,10 +159,16 @@ int main(void)

curl_easy_cleanup(curl);

close(sockfd);
andyguibert marked this conversation as resolved.
Show resolved Hide resolved

if(res) {
printf("libcurl error: %d\n", res);
return 4;
}
}

#ifdef WIN32
WSACleanup();
#endif
return 0;
}