os400: Disable Alt-Svc by default since it's experimental #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to 520f0b4 which added Alt-Svc support and enabled it by default for OS400. Since the feature is experimental, it should be disabled by default. Ref: curl@520f0b4#commitcomment-32792332 Ref: https://curl.haxx.se/mail/lib-2019-02/0008.html Closes #xxxx
bagder
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
I approve of this.
This is also "protecting" ourselves since we want users to be aware that they are testing an experimental feature when they do, as then they are also (or at least should be) aware that the API/ABI might change and that's a strong motivation for the "experimental" tag.
|
coveralls has really gone bananas recently... 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 520f0b4 which added Alt-Svc support and enabled it by
default for OS400. Since the feature is experimental, it should be
disabled by default.
Ref: 520f0b4#commitcomment-32792332
Ref: https://curl.haxx.se/mail/lib-2019-02/0008.html
Closes #xxxx
By keeping Alt-Svc enabled by default in OS400 we're breaking the assertion that experimental features will not be enabled by default. @monnerat has a good point about the testing since we don't get these things exercised when they're disabled by default, but in my opinion we need to only ship stability unless otherwise asked for.