CURLOPT_ADDRESS_SCOPE: fix range check and more #3765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/address-scope
branch
from
b29b74b
to
f69b223
Compare
|
This was discussed on IRC, there is an indication in https://curl.haxx.se/dev/log.cgi?id=20190412030334-23906#prob1 that this might cause a segfault in test 1521 |
Commit 9081014 fixed most of the confusing issues between scope id and scope however 844896d added bad limits checking assuming that the scope is being set and not the scope id. I have fixed the documentation so it all refers to scope ids. In addition Curl_if2ip refered to the scope id as remote_scope_id which is incorrect, so I renamed it to local_scope_id. Closes #3655
bagder
force-pushed
the
bagder/address-scope
branch
from
8cc88b3
to
f407786
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9081014 fixed most of the confusing issues between scope id and scope however 844896d added bad limits checking assuming that the scope is being set and not the scope id.
I have fixed the documentation so it all refers to scope ids.
In addition Curl_if2ip referred to the scope id as remote_scope_id which is incorrect, so I renamed it to local_scope_id.
Closes #3655
(I took that PR, squashed it and fixed some nits and push it here to make sure the CI likes it)