Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing set_in_callback around callback. #3837

Closed
wants to merge 1 commit into from
Closed

Add missing set_in_callback around callback. #3837

wants to merge 1 commit into from

Conversation

@taiyu-len
Copy link
Contributor

@taiyu-len taiyu-len commented May 4, 2019

Happened to find a callback not surrounded by the Curl_set_in_callback functions.
@taiyu-len
Add missing set_in_callback around call to callback.
Loading status checks…
1c35c60
@bagder
bagder approved these changes May 4, 2019
View changes
@bagder
Copy link
Member

@bagder bagder commented May 5, 2019

Thanks!
@bagder bagder closed this in 0eec832 May 5, 2019
@taiyu-len taiyu-len deleted the taiyu-len:set-in-callback branch May 5, 2019
@michaelforney
Copy link
Contributor

@michaelforney michaelforney commented Jun 2, 2019

I noticed that after upgrading to curl 7.65.0, netsurf isn't working with HTTP redirects, and I bisected it down to this commit.

After some investigation, it looks like this is because netsurf is calling curl_multi_add_handle from within the CURLOPT_WRITEFUNCTION callback upon seeing a 3xx HTTP code.

I guess this is the sort of thing this commit is intended to prevent? Just wanted to check before submitting a netsurf bug report.
@jay
Copy link
Member

@jay jay commented Jun 4, 2019

After some investigation, it looks like this is because netsurf is calling curl_multi_add_handle from within the CURLOPT_WRITEFUNCTION callback upon seeing a 3xx HTTP code.

I guess this is the sort of thing this commit is intended to prevent?

Yes that was the intention, please refer to the discussion in #2302.
@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@taiyu-len @bagder @michaelforney @jay