Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config-win32.h: HAVE_GETSOCKNAME #3923

Closed
wants to merge 5 commits into from

Conversation

@Zenju
Copy link
Contributor

commented May 22, 2019

Hi,

just compiled 7.65 on Windows and noticed:

libcurl\lib\connect.c(734,38): warning C4101: 'ssloc': unreferenced local variable

Turns out HAVE_GETPEERNAME is not defined in config-win32.h, but it seems this is by accident?

@bagder
bagder approved these changes May 22, 2019
Copy link
Member

left a comment

👍

@bagder

This comment has been minimized.

Copy link
Member

commented May 22, 2019

BTW, we can and should also define HAVE_IF_NAMETOINDEX while at it, right?

Zenju added 2 commits May 22, 2019
@Zenju

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

BTW, we can and should also define HAVE_IF_NAMETOINDEX while at it, right?

Sounds good. if_nametoindex() requires Vista and later, so I moved the "COMPILER SPECIFIC" part up a bit in order to test for the build target.

@Zenju

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

While at it, maybe also add:

#if defined(HAVE_ZLIB_H)
#define HAVE_LIBZ 1
#endif

? At least on Windows you currently have to manually define both macros to use zlib.

@MarcelRaad

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Sorry, that doesn't look quite right now. Iphlpapi.h availability is independent of the target Windows version, only the individual functions aren't.

@bagder bagder requested a review from MarcelRaad May 23, 2019
@MarcelRaad MarcelRaad self-assigned this May 23, 2019
@MarcelRaad

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Thanks! Squashed and edited slightly to reduce the diff size.

bagder referenced this pull request May 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.