-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config-win32.h: HAVE_GETSOCKNAME #3923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BTW, we can and should also define |
Sounds good. if_nametoindex() requires Vista and later, so I moved the "COMPILER SPECIFIC" part up a bit in order to test for the build target. |
While at it, maybe also add:
? At least on Windows you currently have to manually define both macros to use zlib. |
Sorry, that doesn't look quite right now. Iphlpapi.h availability is independent of the target Windows version, only the individual functions aren't. |
Thanks! Squashed and edited slightly to reduce the diff size. |
Hi,
just compiled 7.65 on Windows and noticed:
libcurl\lib\connect.c(734,38): warning C4101: 'ssloc': unreferenced local variable
Turns out HAVE_GETPEERNAME is not defined in config-win32.h, but it seems this is by accident?