Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc CURLOPT_SEEKDATA #4118

Closed

Conversation

@sstefano69
Copy link
Contributor

@sstefano69 sstefano69 commented Jul 16, 2019

fix variable name

fix variable name
@@ -39,7 +39,7 @@ HTTP, FTP, SFTP
.nf
static int seek_cb(void *userp, curl_off_t offset, int origin)
{
struct data *d = (struct data *)userp;
struct data *our_fd = (struct data *)userp;
lseek(our_fd, offset, origin);

This comment has been minimized.

@bagder

bagder Jul 16, 2019
Member

This fixes one problem but this now instead passes in a struct data pointer to lseek() which also seems wrong.

How about we we instead change the lseek() call to become:

lseek(d->our_fd, offset, origin);
@jay jay closed this in fdcb0f4 Jul 17, 2019
@jay
Copy link
Member

@jay jay commented Jul 17, 2019

Thanks

caraitto added a commit to caraitto/curl that referenced this pull request Jul 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.