Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostip: move code to resolve IP address literals to `Curl_resolv` #4798

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Jan 8, 2020

The code was duplicated in the various resolver backends.

Also, it was called after the call to Curl_ipvalid, which matters in
case of CURLRES_IPV4 when called from connect.c:bindlocal. This
caused test 1048 to fail on classic MinGW.

The code ignores conn->ip_version as done previously in the
individual resolver backends.

Move the call to the resolver_start callback up to appease test 655,
which wants it to be called also for literal addresses.

The code was duplicated in the various resolver backends.

Also, it was called after the call to `Curl_ipvalid`, which matters in
case of `CURLRES_IPV4` when called from `connect.c:bindlocal`. This
caused test 1048 to fail on classic MinGW.

The code ignores `conn->ip_version` as done previously in the
individual resolver backends.

Move the call to the `resolver_start` callback up to appease test 655,
which wants it to be called also for literal addresses.

Closes
@bagder
bagder approved these changes Jan 9, 2020
@jay
jay approved these changes Jan 9, 2020
Copy link
Member

jay left a comment

LGTM but note I reviewed it with whitespace ignored ?w=1

@MarcelRaad MarcelRaad deleted the MarcelRaad:hostip_literals branch Jan 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.