Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrithanks: Make the script exit after printing usage instructions #4883

Closed
wants to merge 1 commit into from

Conversation

gevaerts
Copy link
Contributor

@gevaerts gevaerts commented Feb 5, 2020

No description provided.

@bagder
Copy link
Member

bagder commented Feb 5, 2020

I actually think it should do the equivalent of 5296abe without a tag and only show the usage on -h... If not, this PR will break the delta script.

@danielgustafsson
Copy link
Member

I actually think it should do the equivalent of 5296abe without a tag and only show the usage on -h... If not, this PR will break the delta script.

That makes sense, but still exiting on actual usage printing as per this diff.

@gevaerts
Copy link
Contributor Author

gevaerts commented Feb 5, 2020

I somehow hadn't noticed that contributors.sh was different, even though I checked it for exit usage... You are of course right!

scripts/contrithanks.sh Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented Feb 5, 2020

Thanks!

@bagder bagder closed this in d2411a7 Feb 5, 2020
@gevaerts gevaerts deleted the contrithanks-usage branch February 5, 2020 13:32
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants