Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrithanks: Make the script exit after printing usage instructions #4883

Closed
wants to merge 1 commit into from

Conversation

@gevaerts
Copy link
Contributor

@gevaerts gevaerts commented Feb 5, 2020

No description provided.

@bagder
Copy link
Member

@bagder bagder commented Feb 5, 2020

I actually think it should do the equivalent of 5296abe without a tag and only show the usage on -h... If not, this PR will break the delta script.

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Feb 5, 2020

I actually think it should do the equivalent of 5296abe without a tag and only show the usage on -h... If not, this PR will break the delta script.

That makes sense, but still exiting on actual usage printing as per this diff.

@gevaerts gevaerts force-pushed the gevaerts:contrithanks-usage branch from a2ace5d to 3010a7f Feb 5, 2020
@gevaerts
Copy link
Contributor Author

@gevaerts gevaerts commented Feb 5, 2020

I somehow hadn't noticed that contributors.sh was different, even though I checked it for exit usage... You are of course right!

@gevaerts gevaerts force-pushed the gevaerts:contrithanks-usage branch from 3010a7f to fb6bea1 Feb 5, 2020
scripts/contrithanks.sh Outdated Show resolved Hide resolved
@gevaerts gevaerts force-pushed the gevaerts:contrithanks-usage branch from fb6bea1 to fc06145 Feb 5, 2020
@bagder
bagder approved these changes Feb 5, 2020
@bagder
Copy link
Member

@bagder bagder commented Feb 5, 2020

Thanks!

@bagder bagder closed this in d2411a7 Feb 5, 2020
@gevaerts gevaerts deleted the gevaerts:contrithanks-usage branch Feb 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.