Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test 1238 causing shortly following tests 1242 and 1243 to fail #5364

Closed
wants to merge 1 commit into from
Closed

Fix test 1238 causing shortly following tests 1242 and 1243 to fail #5364

wants to merge 1 commit into from

Commits on May 10, 2020

  1. test1238: avoid tftpd being busy for tests shortly following 

    The tftpd server may still be busy if the total timeout of
25 seconds has not been reached or no sread error was received
during or after the execution of the timeout test 1238.

Once the next TFTP test comes around (eg. 1242 or 1243),
those will fail because the tftpd server is still waiting
on data from curl due to the UDP protocol being stateless
and having no connection close. On Linux this error may not
happen, because ICMP errors generated due to a swrite error
can also be returned async on the next sread call instead.

Therefore we will now just kill the tftpd server after test
1238 to make sure that the following tests are not affected.

This enables us to no longer ignore tests 1242, 1243, 2002
and 2003 on the CI platforms CirrusCI and AppVeyor.

Assisted-by: Peter Wu
Closes curl#5364
    @mback2k
    mback2k committed May 10, 2020
    Configuration menu
    Copy the full SHA
    95c60d8 View commit details
    Browse the repository at this point in the history