-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Install zsh completion #537
Conversation
OPT_ZSH_FPATH=default | ||
AC_ARG_WITH(zsh-functions-dir, | ||
AC_HELP_STRING([--with-zsh-functions-dir=PATH],[Install zsh completions to PATH]) | ||
AC_HELP_STRING([--without-nghttp2],[Do not install zsh completions]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you copy this from nghttp2? this line needs to be changed, also there is another line farther below. did you test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the --with
-with-argument and --with
-without-argument codepaths but not the --without-
codepath. Fixed.
Is zsh used commonly enough for this to be done by default? |
I don't know where to find hard data on zsh's popularity. (There's the debian popcon data and systemd's default behaviour with respect to their zsh completion functions, but I don't know whether either of these datapoints is representative of anything.) I suppose that, if
|
Thanks! I merged your version now so it will install it unconditionally. Let's see if we get any protests... |
Thanks @bagder! |
Fixes #534