Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: add --output-dir #5637

Closed
wants to merge 1 commit into from
Closed

curl: add --output-dir #5637

wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Jul 2, 2020

To allow -o and -O store the received files in a designated directory.

  • test cases
  • verify that --create-dirs works fine together with this option (test 3011)
  • verify that it works with -J (test 3012)
@bagder bagder added the cmdline tool label Jul 2, 2020
@bagder bagder force-pushed the bagder/output-dir branch from 00e5a4f to b3de9e0 Jul 2, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Jul 2, 2020

Three test cases added and --create-dirs is verified to work with it.

bagder added a commit that referenced this pull request Jul 18, 2020
Added test 3008, 3009 and 3010 to verify.

Closes #5637
@bagder bagder force-pushed the bagder/output-dir branch from 2d1a50e to b8b6ed7 Jul 18, 2020
bagder added a commit that referenced this pull request Aug 11, 2020
Added test 3008, 3009 and 3011 to verify.

Closes #5637
@bagder bagder force-pushed the bagder/output-dir branch from b8b6ed7 to c7ef9d4 Aug 11, 2020
@bagder bagder marked this pull request as ready for review Aug 11, 2020
bagder added a commit that referenced this pull request Aug 11, 2020
Works with --create-dirs and with -J

Add test 3008, 3009, 3011, 3012 to verify.

Closes #5637
@bagder bagder force-pushed the bagder/output-dir branch from c7ef9d4 to 19abc8d Aug 11, 2020
tests/runtests.pl Show resolved Hide resolved
@xquery
Copy link
Member

@xquery xquery commented Aug 24, 2020

(maybe I missed it and this exists already) have you considered adding a test with --next to exercise the behaviour of using last defined --output-dir ?

Works with --create-dirs and with -J

Add test 3008, 3009, 3011, 3012 and 3013 to verify.

Closes #5637
@bagder bagder force-pushed the bagder/output-dir branch from 19abc8d to 6881d2e Aug 24, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Aug 24, 2020

A --next test was added now, as number 3013.

@bagder bagder closed this in 5620d2c Aug 24, 2020
@bagder bagder deleted the bagder/output-dir branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.