Remove the port number from IDN host names before converting to ACE #596

Closed
wants to merge 1 commit into
from

Projects

None yet

1 participant

@mkauf
Contributor
mkauf commented Jan 8, 2016

This is a follow-up to pull request #592 . The port number should be removed from a host name before the host name is converted to ACE. The port number is removed by parse_remote_port(), so this function must be called before fix_hostname().

Surprisingly, the tests passed before this commit, so I think that libidn actually supports port numbers in host names. But I'm not sure whether other IDN libraries (e.g. on Windows) also support port numbers.

@mkauf @mkauf mkauf Remove the port number from IDN host names before converting to ACE
f32b850
@bagder bagder closed this in 5d7c937 Jan 10, 2016
@mkauf mkauf deleted the mkauf:idn-connection-reuse-bugfix branch Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment