Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the port number from IDN host names before converting to ACE #596

Closed
wants to merge 1 commit into from

Conversation

@mkauf
Copy link
Contributor

mkauf commented Jan 8, 2016

This is a follow-up to pull request #592 . The port number should be removed from a host name before the host name is converted to ACE. The port number is removed by parse_remote_port(), so this function must be called before fix_hostname().

Surprisingly, the tests passed before this commit, so I think that libidn actually supports port numbers in host names. But I'm not sure whether other IDN libraries (e.g. on Windows) also support port numbers.

@mkauf mkauf force-pushed the mkauf:idn-connection-reuse-bugfix branch to f32b850 Jan 9, 2016
@bagder bagder closed this in 5d7c937 Jan 10, 2016
@mkauf mkauf deleted the mkauf:idn-connection-reuse-bugfix branch Jan 11, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.