Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove the port number from IDN host names before converting to ACE #596
This is a follow-up to pull request #592 . The port number should be removed from a host name before the host name is converted to ACE. The port number is removed by parse_remote_port(), so this function must be called before fix_hostname().
Surprisingly, the tests passed before this commit, so I think that libidn actually supports port numbers in host names. But I'm not sure whether other IDN libraries (e.g. on Windows) also support port numbers.