http: fix compiler warning with CURL_DISABLE_CRYPTO_AUTH
#6509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
Declare `conn` only if `CURL_DISABLE_CRYPTO_AUTH` is not defined. This fixes the following warning: ``` http.c:898:23: warning: unused variable 'conn' [-Wunused-variable] 898 | struct connectdata *conn = data->conn; ``` Closes curl#6509
MarcelRaad
force-pushed
the
disablecryptoauth_unusedvariable
branch
from
b2edc70
to
f185879
Compare
bagder
reviewed
Jan 24, 2021
| struct connectdata *conn = data->conn; | ||
| #endif |
There was a problem hiding this comment.
Couldn't this rather be moved into the #ifdef USE_SPNEGO condition below? It would also match better with the actual use of the negstate variable which also depends on USE_SPNEGO.
There was a problem hiding this comment.
Unfortunately, it's also used in the #ifndef CURL_DISABLE_CRYPTO_AUTH block below for Digest.
|
Is this PR still necessary after ecb1341? |
|
No it isn't! Will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare
connonly ifCURL_DISABLE_CRYPTO_AUTHis not defined.This fixes the following warning: