transfer: Upper-case lengths in chunked encoding #6996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit upper-case hexadecimal lengths in chunked encoding, instead of lower-case. This matches the choice made by hyper, and so test fixtures can easily accommodate both backends.
|
We went with #6987 instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit upper-case hexadecimal lengths in chunked encoding, instead of lower-case. This matches the choice made by hyper, and so test fixtures can easily accommodate both backends.
This is an alternative to #6987, as previously discussed. Note that there was a second chunked encoding code path, which I also changed to use upper case, and three additional test fixtures had to be updated, which were previously not affected when looking at only the hyper configuration.